Closed Bug 1522159 Opened 9 months ago Closed 9 months ago

Move nsSVGAttrTearOffTable to the mozilla namespace

Categories

(Core :: SVG, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Assignee: nobody → longsonr
Attachment #9038563 - Flags: review?(dholbert)
Comment on attachment 9038563 [details] [diff] [review]
patch

Review of attachment 9038563 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, one nit:

::: dom/svg/DOMSVGTransform.cpp
@@ +15,1 @@
>  #include "nsError.h"

This reordering (pivoting these "SVG***" includes to be before nsError.h) seems arbitrary, and seems to disagree with the ordering you've used for most/all other files here.

Logically, "n" sorts before "S" (as does "E", if we ignore the "ns" prefix in nsError).  So it feels like nsError.h is moving further away from its correct sorted position here.

So, probably best to restore the original nsError.h position here, to minimize unnecessary churn?
Attachment #9038563 - Flags: review?(dholbert) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e2afd71fecd
Move nsSVGAttrTearOffTable to the mozilla namespace r=dholbert
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.