Closed Bug 1522159 Opened 2 years ago Closed 2 years ago

Move nsSVGAttrTearOffTable to the mozilla namespace

Categories

(Core :: SVG, enhancement)

Product:
Core
Component:
SVG
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

patch
21.90 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch patch — — Splinter Review
Assignee: nobody → longsonr
Attachment #9038563 - Flags: review?(dholbert)
Comment on attachment 9038563 [details] [diff] [review]
patch

Review of attachment 9038563 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, one nit:

::: dom/svg/DOMSVGTransform.cpp
@@ +15,1 @@
>  #include "nsError.h"

This reordering (pivoting these "SVG***" includes to be before nsError.h) seems arbitrary, and seems to disagree with the ordering you've used for most/all other files here.

Logically, "n" sorts before "S" (as does "E", if we ignore the "ns" prefix in nsError).  So it feels like nsError.h is moving further away from its correct sorted position here.

So, probably best to restore the original nsError.h position here, to minimize unnecessary churn?
Attachment #9038563 - Flags: review?(dholbert) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e2afd71fecd
Move nsSVGAttrTearOffTable to the mozilla namespace r=dholbert

https://hg.mozilla.org/mozilla-central/rev/6e2afd71fecd

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.