Closed
Bug 1522202
Opened 5 years ago
Closed 5 years ago
Switch policy sorting test to be case insensitive
Categories
(Firefox :: Enterprise Policies, enhancement)
Firefox
Enterprise Policies
Tracking
()
RESOLVED
FIXED
Firefox 66
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr60+
|
Details | Review |
We have a test that makes sure policies are sorted alphabetically.
Because it uses sort, we end up having to put things like DNS in the wrong place in the list.
I'd like to move to using localeCompare so that things get put in the proper place when there are multiple capital letters together.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/3d3983a64082 Switch policy sorting test to case insensitive. r=Felipe
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9038619 [details]
Bug 1522202 - Switch policy sorting test to case insensitive.
ESR Uplift Approval Request
If this is not a sec:{high,crit} bug, please state case for ESR consideration
This is a prereq for other policy work. It's just a simple change and has a test.
User impact if declined
Unable to land other policies
Fix Landed on Version
66
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
Just alphabetized and has test.
String or UUID changes made by this patch
None
Attachment #9038619 -
Flags: approval-mozilla-esr60?
Updated•5 years ago
|
Flags: qe-verify+
Updated•5 years ago
|
Flags: in-testsuite+
Comment 5•5 years ago
|
||
Comment on attachment 9038619 [details]
Bug 1522202 - Switch policy sorting test to case insensitive.
Prereq patch for some other Policy Engine fixes with a test included. Approved for 60.6esr.
Attachment #9038619 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Updated•5 years ago
|
QA Whiteboard: [qa-triaged]
Comment 6•5 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
Comment 7•5 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•