Closed Bug 1522202 Opened 1 year ago Closed 1 year ago

Switch policy sorting test to be case insensitive

Categories

(Firefox :: Enterprise Policies, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- fixed
firefox66 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

We have a test that makes sure policies are sorted alphabetically.

Because it uses sort, we end up having to put things like DNS in the wrong place in the list.

I'd like to move to using localeCompare so that things get put in the proper place when there are multiple capital letters together.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/3d3983a64082
Switch policy sorting test to case insensitive. r=Felipe
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Comment on attachment 9038619 [details]
Bug 1522202 - Switch policy sorting test to case insensitive.

ESR Uplift Approval Request

If this is not a sec:{high,crit} bug, please state case for ESR consideration

This is a prereq for other policy work. It's just a simple change and has a test.

User impact if declined

Unable to land other policies

Fix Landed on Version

66

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Just alphabetized and has test.

String or UUID changes made by this patch

None

Attachment #9038619 - Flags: approval-mozilla-esr60?
Flags: in-testsuite+

Comment on attachment 9038619 [details]
Bug 1522202 - Switch policy sorting test to case insensitive.

Prereq patch for some other Policy Engine fixes with a test included. Approved for 60.6esr.

Attachment #9038619 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
QA Whiteboard: [qa-triaged]

This bug doesn't require manual testing.

Flags: qe-verify+ → qe-verify-
You need to log in before you can comment on or make changes to this bug.