Closed
Bug 1522204
Opened 5 years ago
Closed 5 years ago
JS::TraceChildren needs a profiler label with the GCCC category
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: mstange, Assigned: jonco)
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
See this profile: http://bit.ly/2R6njqp
380ms is spent in JS::UnmarkGrayGCThingRecursively -> JS::TraceChildren and it's not categorized under the GC category.
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•5 years ago
|
||
I think we just need to do this.
Assignee: mstange → jcoppeard
Attachment #9039569 -
Flags: review?(pbone)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9039569 [details] [diff] [review] bug1522204-profiler-label I don't know. I'll defer the review to mstange.
Attachment #9039569 -
Flags: review?(pbone) → review?(mstange)
|
Reporter | |
Comment 3•5 years ago
|
||
Comment on attachment 9039569 [details] [diff] [review] bug1522204-profiler-label Review of attachment 9039569 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Yes, this looks correct.
Attachment #9039569 -
Flags: review?(mstange) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71e0d0f25d77 Add profiler label for gray unmarking r=mstange
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•