1522204 - JS::TraceChildren needs a profiler label with the GCCC category

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Markus Stange [:mstange]]

See this profile: http://bit.ly/2R6njqp
380ms is spent in JS::UnmarkGrayGCThingRecursively -> JS::TraceChildren and it's not categorized under the GC category.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1522204-profiler-label

I think we just need to do this.

Comment 2

[Paul Bone [:pbone]]

Comment on attachment 9039569 [details] [diff] [review]
bug1522204-profiler-label

I don't know. I'll defer the review to mstange.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 9039569 [details] [diff] [review]
bug1522204-profiler-label

Review of attachment 9039569 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Yes, this looks correct.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71e0d0f25d77
Add profiler label for gray unmarking r=mstange

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/71e0d0f25d77