1522218 - Stationary scaled border is blurry

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Markus Stange [:mstange]]

In this testcase, I get a blurry border. This is different from non-WebRender and from other browsers.

data:text/html,<div style="width:100px;transform:scale(5);transform-origin:top left;border:2px solid blue;border-radius:10px;">Text

Comment 1

[Darkspirit]

Debian Testing, Macbook Pro
Looked totally fine before.
mozregression --good 2018-05-01 --bad 2018-06-01 --pref gfx.webrender.all:true -a 'data:text/html,<div style="width:100px;transform:scale(5);transform-origin:top left;border:2px solid blue;border-radius:10px;">Text'
8:52.50 INFO: Last good revision: e70e3d46d44190f66bc61b979c334424606578de
8:52.50 INFO: First bad revision: 6e93883796aaffd17c2e0b387bd758749640ce66
8:52.50 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e70e3d46d44190f66bc61b979c334424606578de&tochange=6e93883796aaffd17c2e0b387bd758749640ce66

https://github.com/servo/webrender/compare/bb354abbf84602d3d8357c63c4f0b1139ec4deb1...63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Glenn, is this how you'd expect things to be rendered?

Comment 3

[Glenn Watson [:gw]]

It is what I'd currently expect to see, yes. It should be a reasonably small amount of work to fix this (probably on the order of 1 days work).

Comment 4

[u480271]

https://searchfox.org/mozilla-central/source/layout/painting/FrameLayerBuilder.cpp#6049 Looks like a good start to match the behavior of.

Comment 5

[u480271]

Attachment: Bug 1522218 - Incorporate layout to world scaling for borders.

Implement scaling of borders using the same scale extraction and clamping to
nearest power of two that gecko uses in FrameLayerBuilder::ChooseScale.

Comment 6

[u480271]

Try and talos: https://treeherder.mozilla.org/#/jobs?repo=try&revision=189f5390653ef1b75e7de04b59899074c56552cf

Comment 7

[u480271]

Attachment: Bug 1522218 - An assortment of scaled border wrench reftests.

Depends on D17456

Comment 8

[u480271]

Now with reftests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e85f8c163502397dea68b0d28505b4cf5d9841ae&selectedJob=224883279

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eaa89164318
Incorporate layout to world scaling for borders. r=gw,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/241cc9c8c0cd
An assortment of scaled border wrench reftests. r=gw

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6eaa89164318
https://hg.mozilla.org/mozilla-central/rev/241cc9c8c0cd

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something you think is OK to uplift? Would it be useful on 66 for WebRender experiments?

Comment 12

[u480271]

If Jeff is OK with uplift then I'm happy to.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9040012 [details]
Bug 1522218 - An assortment of scaled border wrench reftests.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Blurry borders with WebRender. We'd like this to improve the quality of our 66 release experiment.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The code changed is only run when WebRender is enabled. There is no risk if WebRender is not enabled.

String changes made/needed

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9038735 [details]
Bug 1522218 - Incorporate layout to world scaling for borders.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Blurry borders with WebRender. We'd like this to improve the quality of our 66 release experiment.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The code changed is only run when WebRender is enabled. There is no risk if WebRender is not enabled.

String changes made/needed

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9040012 [details]
Bug 1522218 - An assortment of scaled border wrench reftests.

Should only affect WebRender experiments in 66; OK for uplift to beta 8.

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/05f992aafb09
https://hg.mozilla.org/releases/mozilla-beta/rev/a6605042490a