Closed Bug 1522218 Opened 7 months ago Closed 7 months ago

Stationary scaled border is blurry

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- disabled
firefox65 --- disabled
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: mstange, Assigned: kamidphish)

References

Details

(Keywords: regression)

Attachments

(2 files)

In this testcase, I get a blurry border. This is different from non-WebRender and from other browsers.

data:text/html,<div style="width:100px;transform:scale(5);transform-origin:top left;border:2px solid blue;border-radius:10px;">Text

Debian Testing, Macbook Pro
Looked totally fine before.
mozregression --good 2018-05-01 --bad 2018-06-01 --pref gfx.webrender.all:true -a 'data:text/html,<div style="width:100px;transform:scale(5);transform-origin:top left;border:2px solid blue;border-radius:10px;">Text'
8:52.50 INFO: Last good revision: e70e3d46d44190f66bc61b979c334424606578de
8:52.50 INFO: First bad revision: 6e93883796aaffd17c2e0b387bd758749640ce66
8:52.50 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e70e3d46d44190f66bc61b979c334424606578de&tochange=6e93883796aaffd17c2e0b387bd758749640ce66

https://github.com/servo/webrender/compare/bb354abbf84602d3d8357c63c4f0b1139ec4deb1...63c71ca9bbe4dec0ebc9c9bc8ab65b06a6b40641

Glenn, is this how you'd expect things to be rendered?

Flags: needinfo?(gwatson)
Priority: -- → P3

It is what I'd currently expect to see, yes. It should be a reasonably small amount of work to fix this (probably on the order of 1 days work).

Flags: needinfo?(gwatson)
Assignee: nobody → dglastonbury

Implement scaling of borders using the same scale extraction and clamping to
nearest power of two that gecko uses in FrameLayerBuilder::ChooseScale.

Pushed by dglastonbury@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6eaa89164318
Incorporate layout to world scaling for borders. r=gw,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/241cc9c8c0cd
An assortment of scaled border wrench reftests. r=gw
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Is this something you think is OK to uplift? Would it be useful on 66 for WebRender experiments?

Flags: needinfo?(dglastonbury)

If Jeff is OK with uplift then I'm happy to.

Flags: needinfo?(dglastonbury) → needinfo?(jmuizelaar)

Comment on attachment 9040012 [details]
Bug 1522218 - An assortment of scaled border wrench reftests.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Blurry borders with WebRender. We'd like this to improve the quality of our 66 release experiment.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The code changed is only run when WebRender is enabled. There is no risk if WebRender is not enabled.

String changes made/needed

Flags: needinfo?(jmuizelaar)
Attachment #9040012 - Flags: approval-mozilla-beta?

Comment on attachment 9038735 [details]
Bug 1522218 - Incorporate layout to world scaling for borders.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

Blurry borders with WebRender. We'd like this to improve the quality of our 66 release experiment.

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The code changed is only run when WebRender is enabled. There is no risk if WebRender is not enabled.

String changes made/needed

Attachment #9038735 - Flags: approval-mozilla-beta?

Comment on attachment 9040012 [details]
Bug 1522218 - An assortment of scaled border wrench reftests.

Should only affect WebRender experiments in 66; OK for uplift to beta 8.

Attachment #9040012 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9038735 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.