Closed Bug 1522228 Opened 9 months ago Closed 9 months ago

ContextElement may hold relative URI (href) without providing the base URI

Categories

(GeckoView :: General, enhancement)

All
Android
enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: esawin, Assigned: esawin)

Details

Attachments

(1 file)

See https://github.com/mozilla-mobile/focus-android/issues/4166.

ContentDelegate.onContextMenu provides the href of an element via ContextElement.linkUri, which may be a relative URI without explicitly providing the baseUri.

We either need to provide the baseUri or guarantee linkUri to be an absolute URI (by prefixing it with the baseUri if required).

Summary: ContextMenu may hold relative URI (href) without providing the base URI → ContextElement may hold relative URI (href) without providing the base URI

I saw the discussion online and just came by to say that I would prefer getting an absolute URI here too. :)

Assignee: nobody → esawin
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ec1e0bc9843
[1.0] Add baseUri to ContextElement and enforce absolute URI for linkUri. r=snorp,geckoview-reviewers
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.