1522233 - Style HR component

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Comment 1

[Kate Hudson :k88hudson]

Test steps:

1. Set browser.newtabpage.activity-stream.discoverystream.config pref to: {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
2. Check to make sure the horizontal line under the "Best of the Web" heading at the top is a light grey colour and 1px high.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4711

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/c90f6688c6096774799d28635502f6e7066fa621
Bug 1522233 - Add styling for HorizonalRule and Hero borders

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5ba3d8cfe5021c71f343f487fdf401018c2359af
Followup Bug 1522233 - Fix test to check HorizontalRule top width instead of bottom
Fix taskcluster/mochitest failure from #4711

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Comment 6

[Brahmini Nagabandi]

Attachment: QA Result : bug -1522233.png

QA Results:

Tested on :

FF Nightly version : 66.0a1 (2019-01-25)
OS : Mac and Windows 10 Pro

Results attached QA Result : bug -1522233.png

Looks good to me.
Closing as verified.