Identify tests that will fail with quantumbar=true (that are not in the browser/components/urlbar/ directory)

RESOLVED FIXED

Status

()

task
P2
normal
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

We should identify tests outside the browser/components/urlbar directory that will fail when we turn on QuantumBar.

I triggered a full-tests try push as an initial step:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea43a64e70e40a2a4815ccd80a8d76aa78e10e0d

(note: the talos tests are just to check they run, not for performance as yet).

I've gone through the try run, and I think I've found all the failing tests. They are now filed and marked as blocking bug 1514162.

Leaving this open, as we'll want to run this again once we've fixed most/all of those bugs.

Marco, I'm confused as to why some of these test related ones are blocking quantumbar-release rather than quantumbar-nightly. I was expecting that we'd need to fix them before we can turn on the pref on permanently for nightly users. Obviously we don't need them for the pref-flip study, but I thought the quantumbar-nightly bug was for preffing on in nightly.

Flags: needinfo?(mak77)

I assumed our "enable in nightly" idea was "partially enable this for some nightly users".
Maybe we should split into enable-in-nightly and enable-for-some-nightly-users. Consider that things like IME and a11y are necessary for a complete pref flip in nightly, and those were already blocking release.

Flags: needinfo?(mak77)

Another try run with the partially landed/WIP patches I've got for fixing tests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec0af01343360709ed764160bbcbeecc7c394d5c

No longer blocks: quantumbar-release
Points: --- → 1
Type: defect → task

The current bugs for the remaining oranges with QuantumBar on are:

Both of these are in progress and are blocking the release via the quantumbar-tests bug.

Iteration: --- → 68.3 - Apr 15 - 28
Blocks: 1547210

Marking as fixed for this iteration - bug 1547210 will manage the next one.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.