Store buffer methods take rarely-used owner pointer

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P5
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

Lots of methods of the individual store buffers take a |StoreBuffer* owner| pointer that is only used if the buffer becomes full. We can tidy this up by giving each buffer a back-pointer to the owner and avoid passing this through all the time.

Assignee

Comment 1

4 months ago

Patch to add the backpointer and remove the unnecessary parameter.

Also, we can remove some destructors by using UniquePtr<> so we don't have to js_delete(). Also move come cold code out of the header file.

Attachment #9038811 - Flags: review?(sphink)
Comment on attachment 9038811 [details] [diff] [review]
bug1522481-storebuffer-tidy

Review of attachment 9038811 [details] [diff] [review]:
-----------------------------------------------------------------

SGTM
Attachment #9038811 - Flags: review?(sphink) → review+

Comment 3

4 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eb75deea9d3
Tidy individual store buffer classes by giving them a back pointer to the owning StoreBuffer r=sfink

Comment 4

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.