1522560 - Use vswhere from Visual Studio Installer and remove in tree vswhere binary

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The vswhere.exe in tree is at version 1.0.62. This is a fair bit behind the current release of 2.5.9. My prime motivation for suggesting we update is easier handling of prerelease Visual Studios.

Our current vswhere will return all Visual Studios installed. This causes flakiness if you have VS2019 installed. However, newer versions of vswhere require the -prerelease flag in order to show prerelease versions.

My understanding is that we do not officially support VS2019 (though we may in future). Our current vswhere invocation picks ups 2019 installs, but if we drop in version 2.5.9 we will only pick up 2017 installs (as we're not invoking with the -prerelease flag). This avoids people footgunning themselves by installing VS2019 and breaking their builds.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1522560 - Update vswhere to 2.5.9. r?ted

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29c348e3962a155de9ede12aa6cb2af9e74a2057

Comment 3

[Mike Hommey [:glandium]]

Considering bug 1512504, I'm inclined to say this is wontfix.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Mike Hommey [:glandium] from comment #3)

Considering bug 1512504, I'm inclined to say this is wontfix.

Will this remove the need to lookup visual studio installs? My understanding, though limited, is that we still do lookups when building with clang as we need headers and libs from msvc?

Comment 5

[(not currently active) Ted Mielczarek]

I don't think bug 1512504 makes a difference here--we still need to use vswhere to locate the Microsoft SDK and include/lib paths. (This sucks but I don't know of a better solution.)

Comment 6

[Mike Hommey [:glandium]]

Actually, vswhere is provided by the Visual Studio installer, at a fixed location (see https://github.com/Microsoft/vswhere/wiki#installing). And the in-tree vswhere is never going to find something that hasn't already installed that file as a side effect.

So I'd argue we should remove the in-tree vswhere file, and pick that file the installer installs.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1522560 - Use system vswhere.exe.

And remove the in-tree one.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #7)

Created attachment 9039388 [details]
Bug 1522560 - Use system vswhere.exe.

And remove the in-tree one.

Does this patch work on your machine?

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks good on my end.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/715355e248a1
Use system vswhere.exe. r=dmajor

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/715355e248a1