1522590 - [Hero] Hero Component Refinements

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Wolasi :wolasi]

Hero
Fix bottom spacing on primary hero story
Font-size of titles for secondary story should be 13px
Remove empty <p> tag for excerpt
Remover borders from borderless hero variant
Title font-weight should 600
For 2/3, 1/3 Hero switch secondary stories to a list
Line-height for excerpt/desc for 2/3 and 1/3 hero primary story should be 20px
Line-height for excerpt for full-width hero primary story should be 24px

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4725

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/096e4bc28be2c09f7faaa5e2ccc1ecfceac437e6
Bug 1522590 – Hero Component Refinements (#4725)

*  Fix bottom spacing on primary hero story

*  Font-size of titles for secondary story should be 13px

* Remove empty <p> tag for excerpt

* Title font-weight should 600

* Remover borders from borderless hero variant

* For 2/3, 1/3 Hero switch secondary stories to a list

* line height tweaks

* enable ghost lines of copy for conssistent spacing

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9d660bf33923

Comment 4

[Brahmini Nagabandi]

Any updates on QA steps?

Comment 5

[Gavin Suntop [:gvn] (they/them)]

No further QA required.