1522599 - make the logic for cxxTypeNeedsMove more straightforward; r=Alex_Gaynor

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Nathan Froyd [:froydnj]]

I started with this to implement move Recv, but thought I might as well try to
land this while move Recv waits for other things.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make the logic for cxxTypeNeedsMove more straightforward; r=Alex_Gaynor

Nested conditionals are hard to read; separating things out should make
the flow somewhat more obvious.

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 9038884 [details] [diff] [review]
make the logic for cxxTypeNeedsMove more straightforward; r=Alex_Gaynor

Review of attachment 9038884 [details] [diff] [review]:
-----------------------------------------------------------------

One potential cleanup, LGTM otherwise.

::: ipc/ipdl/ipdl/lower.py
@@ +572,5 @@
> +
> +    if ipdltype.isCxx():
> +        return ipdltype.isMoveonly()
> +
> +    if not ipdltype.isIPDL():

I think it might be slightly cleaner to express this as:

```
if isIPDL():
   return isArray() or isShmem() ...

return False
```

WDYT?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Alex Gaynor [:Alex_Gaynor] from comment #2)

Comment on attachment 9038884 [details] [diff] [review]
make the logic for cxxTypeNeedsMove more straightforward; r=Alex_Gaynor

Review of attachment 9038884 [details] [diff] [review]:

One potential cleanup, LGTM otherwise.

::: ipc/ipdl/ipdl/lower.py
@@ +572,5 @@

• if ipdltype.isCxx():

•    return ipdltype.isMoveonly()
  

• if not ipdltype.isIPDL():

I think it might be slightly cleaner to express this as:

if isIPDL():
   return isArray() or isShmem() ...

return False

WDYT?

I was aiming for early-exits as much as possible, but perhaps the positive logic is easier to read in this case? Let's just go with the positive logic.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b8503e6109
make the logic for cxxTypeNeedsMove more straightforward; r=Alex_Gaynor

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a3b8503e6109