152260 - AMPM order needs to be cared in time format

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Masaki Katakai]

In current implementation, AM/PM string is always put after
the time format.

"nsDateTimeFormatUnix.cpp"

                 mLocalePreferred24hour ? "%H:%M:%S" : "%I:%M:%S %p",

"%p" will be replaced with localized string of AM/PM.

However, the order "AM/PM 00:00:00" or "00:00:00 AM/PM" is
defined in OS side. In Solaris 9 korean locale, it does not
perefer 24 hours format and AM/PM should be placed before
00:00:00. The localized string of AM/PM is always displayed
after 00:00:00 and it's not good for korean locale.

We currenly checks only mLocalePreferred24hour but need to
check the order AM/PM string.

Comment 1

[Masaki Katakai]

Attachment: patch

Comment 2

[Masaki Katakai]

I've attached the simple patch. Yokoyama-san, could you please take a look?

%X returns "22:00:00" -> mLocalePreferred24hour=TRUE, mLocaleAMPMfirst=FALSE
%X returns "XXX 10:00:00" -> mLocaleAMPMfirst=FALSE
%X returns "10:00:00 XXX" -> mLocaleAMPMfirst=FALSE

Comment 3

[Roy Yokoyama]

Comment on attachment 87902 [details] [diff] [review]
patch

/r=yokoyama;  I am not very familiar with non-Win32 platforms; but I can
sympathize your formating trouble.  As in  Win32, it will be nice to be able to
custmize the separator symbol ':' and order of 'H','M','I'....
( I can't believe I am braggin MS-Win32 )

Comment 4

[Masaki Katakai]

Assigned to myself and request sr.

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 87902 [details] [diff] [review]
patch

sr=blizzard

Comment 6

[Masaki Katakai]

Thank you very much for reviews, Yokoyama-san and Blizzard.
Checked into Trunk.

Comment 7

[Masaki Katakai]

verified on local build today.

Comment 8

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 9

[lchiang]

katsumi - can you verify this bug fix in 1.0 branch?  When verified, pls replace
fixed1.0.1 keyword with verified1.0.1.  Thanks.

Comment 10

[Kasumi]

Katakai-sann:
We dont have Solaris environment.
Could you please verify this?

Comment 11

[Masaki Katakai]

Verified this on 1.0.1.