Closed Bug 1522642 Opened 5 years ago Closed 5 years ago

The new about:config could be benefit from not rely on the usual keyboard debounce

Categories

(Toolkit :: Preferences, enhancement)

Product:
Toolkit
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: timdream, Unassigned)

References

(Depends on 1 open bug)

Details

Currently the new about:config rely on the delayed keyboard event to trigger search. This is because we don't want to trigger search too often ("debounce").

We should be able to remove that by employing what's done in about:preferences in bug 1384830.

https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/browser/components/preferences/in-content/findInPage.js#251-283

This is achieved by starting triggering search as the user types, but make sure the search is interruptable every 16ms; the stale search is canceled if the string to search is changed during an interruption.

Summary: The new about:config could be benefit from not rely on the usual debounce → The new about:config could be benefit from not rely on the usual keyboard debounce

While this is very interesting for the responsiveness of the user-facing Preferences page, for me this is an easy WONTFIX for the new "about:config" page, because of the complexity of handling partial results in conjunction with the data changing because of the observer.

This is not only in production code, but also for tests, that can be much, much simpler given the monolithic synchronous update that happens now when searching.

Thanks for the report anyways, I didn't know the Preferences code used this advanced technique!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.