Closed Bug 1522696 Opened 5 years ago Closed 5 years ago

wptrunner raises ValueError in install_windows_font, on Windows/arm64

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

I'm trying to run web-platform tests in a Windows / arm64 environment and getting a ValueError thrown at

https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/testing/web-platform/tests/tools/wptrunner/wptrunner/font.py#95

        return bool(ctypes.windll.user32.SendMessageW(hwnd_broadcast,
                                                      wm_fontchange))

The ValueError is

ValueError: Procedure probably called with not enough arguments(8 bytes missing)

I wonder if it would help to provide wParam and lParam also:

https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-sendmessagew

This change avoids the ValueError and allows me to run wpt on Windows/arm64. wpt continues running fine on x86 (comment 2).

Attachment #9039009 - Flags: review?(james)
Comment on attachment 9039009 [details] [diff] [review]
specify parameter types and all parameters in SendMessageW calls

Review of attachment 9039009 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #9039009 - Flags: review?(james) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/684d038b8eea
Specify argument types and all parameters when calling SendMessageW from wpt font installation code; r=jgraham
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15100 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: