Closed Bug 1522736 Opened 6 years ago Closed 6 years ago

Fix implicit conversion error in BigInt initialization

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1522738

People

(Reporter: terpri, Unassigned)

Details

Static analysis reports an error when defining a single-parameter constructor in BigIntType.cpp:

[task 2019-01-24T19:54:12.049Z] 19:54:12    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:1182:13: error: bad implicit conversion constructor for 'RadixInfo'
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -    constexpr RadixInfo(uint8_t radix)
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -              ^
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:1182:13: note: consider adding the explicit keyword to the constructor
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -    constexpr RadixInfo(uint8_t radix)
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -              ^
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -              explicit
[task 2019-01-24T19:54:12.050Z] 19:54:12     INFO -  1 error generated.
[task 2019-01-24T19:54:12.050Z] 19:54:12     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1106: recipe for target 'BigIntType.o' failed
[task 2019-01-24T19:54:12.051Z] 19:54:12    ERROR -  make[4]: *** [BigIntType.o] Error 1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.