Closed Bug 1522737 Opened 6 years ago Closed 6 years ago

Fix BigInt -Wparentheses warning

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1522738

People

(Reporter: terpri, Unassigned)

Details

clang reports a -Wparentheses warning in BigIntType.cpp (which causes an error on the try server due to -Werror being set):

[task 2019-01-24T21:33:05.487Z] 21:33:05     INFO -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp: In static member function 'static JS::BigInt* JS::BigInt::createFromInt64(JSContext*, int64_t)':
[task 2019-01-24T21:33:05.488Z] 21:33:05    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:1587:37: error: suggest parentheses around comparison in operand of '==' [-Werror=parentheses]
[task 2019-01-24T21:33:05.489Z] 21:33:05     INFO -     MOZ_ASSERT(res->isNegative() == n < 0);
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.