Closed Bug 1522760 Opened 10 months ago Closed 9 months ago

[remote-dbg-next] Inconsistent runtime name when debugging Reference Browser

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jdescottes, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Prerequisite: Reference Browser + USB debugging enabled on device.

STRs:

  • open about:debugging
  • connect to reference browser running on Android device
  • inspect a tab

ER: The runtime name should be the same in sidebar/runtime-page/toolbox
AR: In the sidebar the runtime is called Firefox Custom. In the runtime page it is called Mozilla Nightly. In about:devtools-toolbox, it is called Fennec!

Priority: -- → P3
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P3 → P1
Attached image runtime-info-mark.png

I attach a screenshot as the current state of sidebar, RuntimePage and about:devtools-toolbox.
And, wrote the information as following table.

component runtime name version device name
sidebar Firefox Custom Pixel 2
RuntimePage Mozilla Fennec 67.0a1 Pixel 2MUFU
about:devtools-toolbox Fennec 67.0a1 Pixel 2MUFU

The sources of each information are, sidebar is from ADB, others are from appinfo. The difference of RuntimePage and about:devtools-toolbox is that RuntimePage use appinfo.brandName as runtime name, and about:devtools-toolbox uses appinfo.name.
Ideally, because same information displays at all places, make to display as follows as first step.

runtime name: Fennec -> appinfo.name
version: 67.0a1 -> appinfo.version
device name: Pixel 2MUFU -> appinfo.deviceName

And, because the source of sidebar information differs, I think we can not display same information from the beginning. Instead that, we may be able to update the sidebar item after connecting the runtime. We can display the version as well though, it may duplicated to https://bugzilla.mozilla.org/show_bug.cgi?id=1505125.
Anyway, I will proceed till here.

Also, getting app name such as Reference Browser seems to need to modify at Android side, it might take time.

(In reply to Daisuke Akatsuka (:daisuke) from comment #1)

runtime name: Fennec -> appinfo.name

No, brandName seems better. Because appinfo.name is Fennec when launch Firefox Beta .

Thanks for the detailed report Daisuke!

I agree with your plan, use brandName in RuntimePage and about:devtools-toolbox. I think we can try updating the runtime name in the sidebar after we connect, I wonder if it will feel weird to see this information change.

I would also not add the version to the sidebar for now. As you said, we have a dedicated UX bug for the sidebar, so let's wait for that. Can we file a follow up bug dedicated to this blocked on Bug 1505125?

Also, getting app name such as Reference Browser seems to need to modify at Android side, it might take time.

Can we also file a follow up for this?

Thank you for your feedback, Julian!

(In reply to Julian Descottes [:jdescottes] from comment #3)

I agree with your plan, use brandName in RuntimePage and about:devtools-toolbox. I think we can try updating the runtime name in the sidebar after we connect, I wonder if it will feel weird to see this information change.

Since I made a prototype which update the sidebar, I will send to Phabricator without review flag.
Please try the patch and give your feeling.

I would also not add the version to the sidebar for now. As you said, we have a dedicated UX bug for the sidebar, so let's wait for that. Can we file a follow up bug dedicated to this blocked on Bug 1505125?

Okay!

Also, getting app name such as Reference Browser seems to need to modify at Android side, it might take time.

Can we also file a follow up for this?

Let me investigate a bit more. But, if I felt it seems it takes long time, I'll file the bug.

See Also: → 1530925
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1c9f35a9652
Use appinfo.brandName instead of appinfo.name. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/fc03a8b4a47b
Update sidebar item content which connected. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/39ceb46c4c45
Modify a test to confirm whether the name of sidebar item was updated. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
See Also: → 1589805
You need to log in before you can comment on or make changes to this bug.