1522774 - Rounded titlebar corners are not anti-aliased with basic compositor

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Kestrel]

Attachment: aliased-corner.png

On Ubuntu 18.10 (X & Wayland) the rounded titlebar corners have noticeable aliasing with the default basic compositor. Does not occur with layers acceleration, WebRender or Wayland backend.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c227ac918eb1ab0b702d4424603faeb836f2b1c&tochange=64d38928ff5a59fb8214a0ee2472dccd6f16705d

Regressed by Bug 1521012.

Comment 1

[Andrew Overholt [:overholt]]

Martin, can you take a look here?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Yes, it's because we can't use ARGB visual for the toplevel window due to Bug 1516224 for Basic compositor. There's no fix for that unless the video playback is fixed.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #3)

Yes, it's because we can't use ARGB visual for the toplevel window due to
Bug 1516224 for Basic compositor. There's no fix for that unless the video
playback is fixed.

To be correct here this happens with X11 SHM backend only. It may be possible to fix WindowSurfaceX11Image (Bug 1521908) but it's slower than the SHM backend.

Comment 5

[Tim Spurway [:tspurway]]

:jimm - this one needs a priority?

Comment 7

[Jim Mathies [:jimm]]

Maybe that wasn't right.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Note: Bug 1525874 allow to override the shape mask for toplevel window, but that introduces back Bug 1516224.

Comment 9

[Patricia Lawless]

Bulk change of P3 carryover bugs to wontfix for 68.

Comment 10

[Gregory Pappas [:gregp]]

Basic Compositor was removed in bug 1727876. Can you still reproduce this?

Comment 11

[Kestrel]

I cannot reproduce it on Ubuntu 22.10 with MOZ_ENABLE_WAYLAND=0 and SW-WR.