<input type="date/time"> popup text is unreadable if dark mode is enabled

VERIFIED FIXED in Firefox 66

Status

()

defect
P1
normal
VERIFIED FIXED
4 months ago
3 months ago

People

(Reporter: itiel_yn8, Assigned: timdream)

Tracking

({regression})

unspecified
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66+ fixed, firefox67 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

4 months ago
Posted image <input type="date">

See screenshots.

This is a regression from bug 1512489.

(Reporter)

Comment 1

4 months ago
Posted image <input type="time">
(Reporter)

Updated

4 months ago
Flags: needinfo?(timdream)

Can't think of how this can break on top of my head ... thanks for filing.

Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(timdream)
(Reporter)

Comment 3

4 months ago

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)

Can't think of how this can break on top of my head ... thanks for filing.

Forgot to add that prior to bug 1512489, these popups were not affected by the dark mode at all (their background was still white if dark mode was enabled).

I removed the "active" attribute in bug 1512489 and didn't realize there is a selector in this sheet.
These CSS variables was added in bug 1317581 to reset background color of the picker.

Priority: -- → P1

Comment 5

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/262e222628fb
Correct datetime picker panel background color r=dao

Need uplift

Flags: needinfo?(timdream)

Comment 7

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
(Reporter)

Comment 8

4 months ago

Fixed on latest Nightly.

Are there any plans on adding a dark flavor to the date/time picker? Should I file a bug?

Status: RESOLVED → VERIFIED

(In reply to Itiel from comment #8)

Are there any plans on adding a dark flavor to the date/time picker? Should I file a bug?

Please file a bug.

Comment on attachment 9039376 [details]
Bug 1522779 - Correct datetime picker panel background color r=jaws

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1512489

User impact if declined

The background color of the date time picker will be incorrect.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

one line fix.

String changes made/needed

none

Flags: needinfo?(timdream)
Attachment #9039376 - Flags: approval-mozilla-beta?
(Reporter)

Updated

4 months ago
See Also: → 1523990

Comment on attachment 9039376 [details]
Bug 1522779 - Correct datetime picker panel background color r=jaws

Verified in Nightly, let's uplift to fix this new regression.
Should land for beta 4.

Attachment #9039376 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.