Unused class member: nsHttpChannel::mHasQueryString

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: kershaw, Assigned: kershaw)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

Honza, do you think we can remove mHasQueryString?

Flags: needinfo?(honzab.moz)

(In reply to Kershaw Chang [:kershaw] from comment #1)

Honza, do you think we can remove mHasQueryString?

According searchfox, it looks unused. you may also remove the call to HasQueryString(), it doesn't seem to update |this| or anything.

Flags: needinfo?(honzab.moz)
Assignee: nobody → kershaw
Priority: -- → P1
Whiteboard: [necko-triaged]

Is this still a P1 for this release cycle?

Flags: needinfo?(kershaw)

(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #3)

Is this still a P1 for this release cycle?

Yes, I think I can fix this quickly.

Flags: needinfo?(kershaw)

Comment 6

4 months ago
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de51545099a6
Remove unused class member mHasQueryString r=mayhemer

Comment 7

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.