Closed
Bug 1522786
Opened 5 years ago
Closed 5 years ago
Unused class member: nsHttpChannel::mHasQueryString
Categories
(Core :: Networking: HTTP, enhancement, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: kershaw, Assigned: kershaw)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
It seems that mHasQueryString [1] is not used anywhere in tree.
|
Assignee | |
Comment 1•5 years ago
|
||
Honza, do you think we can remove mHasQueryString?
Flags: needinfo?(honzab.moz)
|
||
Comment 2•5 years ago
|
||
(In reply to Kershaw Chang [:kershaw] from comment #1)
Honza, do you think we can remove mHasQueryString?
According searchfox, it looks unused. you may also remove the call to HasQueryString(), it doesn't seem to update |this| or anything.
Flags: needinfo?(honzab.moz)
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → kershaw
Priority: -- → P1
Whiteboard: [necko-triaged]
Is this still a P1 for this release cycle?
Flags: needinfo?(kershaw)
|
|
Assignee | |
Comment 4•5 years ago
•
|
||
(In reply to Emma Humphries, Bugmaster ☕️🎸🧞♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #3)
Is this still a P1 for this release cycle?
Yes, I think I can fix this quickly.
Flags: needinfo?(kershaw)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de51545099a6 Remove unused class member mHasQueryString r=mayhemer
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•