1522793 - Remove disabling of ESLint rules indent-legacy and padded-blocks in devtools/client/dom/.eslintrc.js

Status: RESOLVED FIXED

(DevTools :: DOM, enhancement, P3)

Description

[Mark Banner (:standard8)]

For some reason the indent-legacy and padded-block rules are disabled in devtools/client/dom/.eslintrc.js for the files in that directory and its sub-directories.

Bug 1201475 didn't really explain why they were disabled, and I think it might have been an error.

Could we remove these explicit disables and enable those rules on the files?

Note: bug 1518283 is rolling out padded-block across the whole tree, and indent-legacy is already enabled for the rest of devtools, so this would be making devtools/client/dom consistent with the rest of devtools.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1522793 - Remove disabling of ESLint rules indent-legacy and padded-blocks; r=standard8

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report, make sense to me.

Patch attached, and Try seems to be ok with that:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ffd35e991de2fd9a7204855a80f05c4c07df202

Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c08cca8ae53
Remove disabling of ESLint rules indent-legacy and padded-blocks; r=Standard8

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3c08cca8ae53