Closed
Bug 1522809
Opened 5 years ago
Closed 5 years ago
Nodes with `name="attributes"` break the markup view
Categories
(DevTools :: Inspector, defect, P2)
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: Yakup.Atas, Assigned: miker)
Details
(Keywords: testcase)
Attachments
(3 files, 1 obsolete file)
Comment hidden (obsolete) |
Comment 1•5 years ago
|
||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
20190125095457
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → Inspector
Ever confirmed: true
Keywords: testcase
OS: Unspecified → All
Product: Firefox → DevTools
Hardware: Unspecified → All
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
•
|
||
HTML documents containing the following line break the markup view:
<img name="attributes">
STR
- Open this test file.
- Right-click and inspect element.
Actual
The markup view is empty.
Expected
The markup view displays markup.
Comment hidden (typo) |
Assignee | ||
Comment 5•5 years ago
|
||
The following exception is thrown:
Error while calling actor 'inspector's method 'getWalker' this.rawNode.attributes is not iterable protocol.js:1042:5
writeError resource://devtools/shared/protocol.js:1042
handler resource://devtools/shared/protocol.js:1222
handler resource://devtools/shared/protocol.js:1222
_queueResponse resource://devtools/shared/protocol.js:1056
handler resource://devtools/shared/protocol.js:1218
onPacket resource://devtools/server/main.js:1279
receiveMessage resource://devtools/shared/transport/child-transport.js:66
_addListener resource://devtools/shared/transport/child-transport.js:40
ready resource://devtools/shared/transport/child-transport.js:57
_onConnection resource://devtools/server/main.js:868
connectToParent resource://devtools/server/main.js:289
onConnect resource://devtools/server/startup/frame.js:59
makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:109
<anonymous> resource://devtools/server/startup/frame.js:80
<anonymous> resource://devtools/server/startup/frame.js:20
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #9040474 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Summary: Clobbering DevTools inspector → Nodes with `name="attributes" break the markup view
Assignee | ||
Updated•5 years ago
|
Summary: Nodes with `name="attributes" break the markup view → Nodes with `name="attributes"` break the markup view
Assignee | ||
Comment 7•5 years ago
|
||
This is another very specific issue.
If you have <img name="attributes"/>
in the dom then document.attributes
will return the <img>
tag.
In the source we bail if !this.rawNode.attributes
but if we are on the document node this returns the image tag. Because the image tag is not a NamedNodeMap
trying to iterate over the tag throws the error.
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85f55cb935f6 Nodes with `name="attributes"` break the markup view r=rcaliman
Comment 9•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.