1522822 - Ensure the width of the name and value columns is equal even in smaller windows

Status: NEW

(Toolkit :: Preferences, defect, P3)

Description

[plaice.adam+persona]

Attachment: new_and_old_about_config.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

(Firstly, thanks for the nice, shiny, new about:config!)

Open the new about:config page, with Firefox taking up half the width of the screen. (This could be achieved in many ways: "snapping" the window to one side, as in Windows and Ubuntu, using a tiling manager, just not having the window maximised etc.).

Actual results:

The interface became hard to read, with the single-word values (such as booleans, URLs and even long integers) split over multiple lines. See attached screenshot of the old and new interfaces side-by-side (this is a screenshot of two screenshots, as I couldn't figure out how to attach more than one file...).

Expected results:

The relative width of the columns could be changed (the "name" column could easily be more narrow and possibly the buttons could be in two rows rather than one, when the width of the screen is decreased). Alternatively, the names and/or values could be truncated (overflow hidden).

Comment 1

[:Paolo Amadini]

Thanks for filing this bug! I'll try and find a way to fix this, probably by ensuring that the desired 50% column width is applied consistently.

Comment 2

[Matthias :Kammueller]

In the mockup, I solved this with a min-width for the body element, consistent to about:preferences.
Since we have a different design for the mobile versionsversions anyways, I think this is a good way to drive it and keep things consistent.

Comment 3

[:Paolo Amadini]

(In reply to :Matthias Kammüller [travelling Dec 13 until Feb 1] from comment #2)

In the mockup, I solved this with a min-width for the body element, consistent to about:preferences.

We still have the min-width, but if I understand correctly what's happening in the screenshot, the preference names are pushing the first column so it uses most of the space. It's also possible that zoom level affects this, since by design the min-width is in pixels. If you'd like to take a look in more detail, you're very welcome!

Comment 4

[Matthias :Kammueller]

I don't have accesses to a computer until Feb 1st, but I can take a look at it once I'm at home again.

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1522822: Drive-by comment fixes; r?nbp

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 9040366 [details]
Bug 1522822: Drive-by comment fixes; r?nbp

sorry, typo in bug number.

Comment 7

[:Paolo Amadini]

This will be solved by bug 1524855. I'm leaving this open so it can be verified separately.