Closed
Bug 1522853
Opened 5 years ago
Closed 5 years ago
Add "Prefer non-string APIs" language to review guidelines
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla67
People
(Reporter: chutten, Assigned: chutten)
Details
Attachments
(1 file)
In bugs like bug 1313327 we should prefer not writing String-based APIs when we could instead write one that's more type-safe.
In general, we can consider any API that takes strings to be a Parser and we don't want to write parsers unless we have to.
This should be added to the review docs so we don't forget.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ee39773e0ac Document that Telemetry prefers non-String APIs where possible. r=janerik
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•