Closed
Bug 1522867
Opened 5 years ago
Closed 5 years ago
Remove 8px bottom margin on source/domain for hero secondary items
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: wolasi, Assigned: Mardak)
References
Details
(Keywords: github-merged)
User Story
QA steps: use dev-test-all and for all Hero items except the large first one, there should be no excessive whitespace below the last line (the domain)
Attachments
(2 files)
QA Results : Bug - 1522867.png
- Remove bottom margin on image-wrapper for primary hero item on full-width and 2/3 variants
- Remove 8px bottom margin on source/domain for hero secondary items
|
Assignee | |
Comment 1•5 years ago
|
||
The first item was covered in bug 1522590
Assignee: nobody → edilee
Depends on: 1522590
Priority: -- → P1
Summary: [Hero] Layout tweaks → Remove 8px bottom margin on source/domain for hero secondary items
|
|
Assignee | |
Comment 2•5 years ago
|
||
This was fixed in https://github.com/mozilla/activity-stream/commit/c3184821be567ceb31cb94c1dcb4ecd24ba2205e
Keywords: github-merged
|
|
Assignee | |
Updated•5 years ago
|
Iteration: --- → 66.4 - Jan 21 - 27
|
|
Assignee | |
Updated•5 years ago
|
User Story: (updated)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 4•5 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-04)
OS : Mac and Windows 10 Pro
Results attached QA Results : Bug - 1522867.png
Closing as verified.
|
|
||
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Updated•5 years ago
|
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 5•5 years ago
•
|
||
Re-opening because of the following :
In the screenshot attached, it looks like there is extra space above and below the margin. Is this still acceptable?
Had this question referring to 1/3 Hero components.
Flags: needinfo?(edilee)
|
|
||
Comment 6•5 years ago
|
||
Had an offline sync with @Wolasi.konu about the same^, was told that a bug has been filed for this.
Tracking here : https://bugzilla.mozilla.org/show_bug.cgi?id=1524632
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(edilee)
|
|
Assignee | |
Updated•5 years ago
|
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•