15229 - port Mac binary stuff to new world

Status: VERIFIED DUPLICATE of bug 937

(Core :: Networking, defect, P3)

Description

[Steve Dagley]

To expond upon gagan's oh so brief summary:

In Mac 4.04 we added the capability to optionally specify MacBinary encoding on a
file in a FORM submit using the following syntax:

        INPUT TYPE="FILE" enctype="MACBINARY"

This needs to be implemented in the brave new Mozilla world.

For reference the 4.x work was done under bugsplat bug #69439

Comment 1

[Eric Pollmann]

Ah... M14..  :)
Well, the code I will check in as soon as the tree opens, a rewrite of parts of
multipart form posting, is here:

mozilla/layout/html/forms/src/nsFormFrame::ProcessAsMultipart()

The gist of it is that for each file input element <INPUT TYPE=FILE>, it reads
the filename, gets the file length, reads in the file, and writes it to a temp
file.

Also of interest is:
mozilla/layout/html/forms/src/nsFileControlFrame::MouseClick

This is the actual implementation of the file input element.  It currently is
just a text input element and a button element rigged so that when you click on
the button element, it pops up a file dialog box.  The file dialog box gets a
filespec, then converts it to a char* and sets that value in the content model.

Just as a rough guess, you will probably have to modify nsFileControlFrame so
that it stores the preference to encode the file somewhere, and nsFormFrame to
check for this preference, then use it, somewhere near ProcessAsMultipart.

Comment 2

[Peter Trudelle]

mass moving m14 bugs to m15

Comment 3

[Steve Dagley]

mcafee changed the component to XP Toolkit/Widgets which is wrong.  This work
touches both Necko and Layout so I'm changing it to Necko.  mcafee can remove
himself from the cc: list after he reads that he's been a bad boy :-)

Comment 4

[Chris McAfee]

W

Comment 5

[leger]

Resetting QA Contact.

Comment 6

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Comment 7

[Steve Dagley]

I plan to get this in for M17 but need sfraser to restore Internet Config to the 
Mac build before I can land anything

Comment 8

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 9

[Simon Fraser [no longer active]]

Ducarroz is doing related stuff for AppleDouble in mail.

Comment 10

[Steve Dagley]

Not that it's an excuse for leaving this one languishing for so long but for most 
of the past 9 months I've been concentrating on the Mac version of 4.x.  Now I'm 
back to working on Mozilla.

As to the future of this bug, I do plan on resurrecting the code I did for 4.x 
but I may skip requiring the enctype parameter and just use Internet Config to 
determine if the resource fork of the file is significant and do the MB encode if 
so.  I believe IE uses this logic.  Any comments on that plan?

I don't think the work Ducarroz is doing for AppleDouble in mail is directly 
related unless he's doing some sort of generalized encoder API but I'll certainly 
talk to him about it.  How common is MB encoding for Mac attachments and should 
we consider offering it as well as AS encoding?

Comment 11

[Oliver Klee]

Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.

Comment 12

[Steve Dagley]

Marking this as a dup of 937 and changing that one to reflect new plan for 
determining if encoding is appropriate


*** This bug has been marked as a duplicate of 937 ***

Comment 13

[Tom Everingham]

verified dup