Closed Bug 1522909 Opened Last year Closed Last year

[Navigation] Add an optional header

Categories

(Firefox :: New Tab Page, enhancement, P1)

66 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Status
firefox66 --- fixed

People

(Reporter: wolasi, Assigned: pdahiya)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

Add an optional header to the navigation component with the same properties as the headers on other components.
Displaying the header should be optional.

Assignee: nobody → pdahiya

And let's make the font-weight for the title in all component headers 600

Keywords: github-merged
Iteration: --- → 66.4 - Jan 21 - 27
Priority: -- → P1

This landed in https://github.com/mozilla/activity-stream/commit/160fca58e29b63405bdb67d6ef8cb3df41574fcf but did not have the expected bug number format (space) in the commit message.

" Bug-1522909 - Add optional header to navigation and update header font weight"

Exported in bug 1523023 https://hg.mozilla.org/mozilla-central/rev/4fb9d276e063

Blocks: 1523023
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi,
Can you update QA steps, thanks.

Flags: needinfo?(pdahiya)

How to test:

Flags: needinfo?(pdahiya)

NI Brahmini for helping QA this fix. Thanks!

Flags: needinfo?(bnagabandi)
Flags: needinfo?(bnagabandi)

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-02-10)
OS : Mac and Windows 10 Pro

Observations :

  1. On New Tab , search returns 2 results for Navigation: (attachment : Screen Shot 2019-02-10 at 10.42.43 PM.png)
  • Navigation centered
  • Navigation left-align
  1. On opening URL https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all , search returns 11 results for Navigation component but only 1 result for Navigation centered. (attachment : Screen Shot 2019-02-10 at 10.42.28 PM.png )

"type": "Navigation",
"header": {
"title": "Navigation centered"
},

Closing as verified.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.