1522940 - When we're told to not follow redirects, we shouldn't try to follow them

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we check the loadinfo's "don't follow redirects" flag way late into the redirect processing pipeline, after we have done a bunch of work (and possibly failed the load, e.g. due to a malformed Location header).

We should be checking it much earlier, I would think.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1522940. Bail out of redirect processing immediately if our loadinfo says to not follow redirects. r=mayhemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d821bddaa20
Bail out of redirect processing immediately if our loadinfo says to not follow redirects.  r=mayhemer

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2d821bddaa20

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Given where we are in the cycle, is this something we should consider uplifting to Beta or can it ride the trains?

Comment 5

[Boris Zbarsky [:bzbarsky]]

I think it's fine for this to ride the trains. It's not a new problem, it only affects certain very specific uses of the fetch API, and it hasn't seemed to be a problem in the wild so far.