Remove this.emit("startup", this) from Extension.jsm
Categories
(WebExtensions :: General, task, P5)
Tracking
(Not tracked)
People
(Reporter: robwu, Assigned: zombie)
References
Details
Attachments
(1 obsolete file)
The startup
method of the Extension
class in Extension.jsm emits the "startup" event before loading any extension APIs. This was originally introduced to support embedded WebExtensions, but that code has since been removed (in bug 1500265).
This event overlaps with the "startup" event from ext-backgroundPage.js, so before removing the event, we need to make sure that there is no other listener that relies on the "startup" event in Extension.jsm.
(not to be confused with the other "startup" event that is dispatched to Management
(which is used in ext-*.js scripts as extensions.on("startup", ...)
).)
To avoid ambiguity (and help with code search in the future), we can also consider renaming "startup" in ext-backgroundPage.js to "background_started_up" or something like that.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Hey Shivam, how's it going with this bug? If you're stuck anywhere, let us know and we can try to help out. :)
Comment 3•5 years ago
|
||
Hey Caitlin,
Will be back soon after exams and will update the PR :)
Comment 4•5 years ago
|
||
There hasn't been much activity on this, so we are re-opening this for everyone to work on. We are happy to assign a contributor after they submitted a patch.
Reporter | ||
Comment 5•5 years ago
|
||
I'm unmarking this as a good-first-bug, because the removal is not so simple. There are a few issues, some resolved, some unresolved. I listed some of the necessary changes at https://phabricator.services.mozilla.com/D19908#679805 and will revisit this bug eventually.
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
I was in the neighborhood for bug 1624235.
Description
•