Closed Bug 1522973 Opened 5 years ago Closed 4 years ago

Remove this.emit("startup", this) from Extension.jsm

Categories

(WebExtensions :: General, task, P5)

64 Branch
task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1624235

People

(Reporter: robwu, Assigned: zombie)

References

Details

Attachments

(1 obsolete file)

The startup method of the Extension class in Extension.jsm emits the "startup" event before loading any extension APIs. This was originally introduced to support embedded WebExtensions, but that code has since been removed (in bug 1500265).

This event overlaps with the "startup" event from ext-backgroundPage.js, so before removing the event, we need to make sure that there is no other listener that relies on the "startup" event in Extension.jsm.
(not to be confused with the other "startup" event that is dispatched to Management (which is used in ext-*.js scripts as extensions.on("startup", ...)).)

To avoid ambiguity (and help with code search in the future), we can also consider renaming "startup" in ext-backgroundPage.js to "background_started_up" or something like that.

Mentor: rob
Keywords: good-first-bug
Priority: -- → P5
Assignee: nobody → shivams2799
Status: NEW → ASSIGNED
See Also: → 1534969

Hey Shivam, how's it going with this bug? If you're stuck anywhere, let us know and we can try to help out. :)

Hey Caitlin,

Will be back soon after exams and will update the PR :)

There hasn't been much activity on this, so we are re-opening this for everyone to work on. We are happy to assign a contributor after they submitted a patch.

Assignee: shivams2799 → nobody
Status: ASSIGNED → NEW

I'm unmarking this as a good-first-bug, because the removal is not so simple. There are a few issues, some resolved, some unresolved. I listed some of the necessary changes at https://phabricator.services.mozilla.com/D19908#679805 and will revisit this bug eventually.

Assignee: nobody → rob
Mentor: rob
Type: enhancement → task
Keywords: good-first-bug
Attachment #9044121 - Attachment is obsolete: true

I was in the neighborhood for bug 1624235.

Assignee: rob → tomica
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: