1523003 - Remove the force-ms-compatibility for clang-cl

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1523003 - Change clang-cl compiler version to be the clang version rather than MSVC r?dmajor

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

Comment 3

[Tom Ritter [:tjr]]

If any issues arise from this; please ni glandium :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/579d66b2e57d
Remove the force-ms-compatibility for clang-cl. r=glandium

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 579d66b2e57d (Bug 1523003) for build bustages at test_toolchain_configure.py

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/47aa4d0b53749a04760a41213d88c2cfed80a870

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=579d66b2e57dcaf66fab49df4be13ceb84ca150b&selectedJob=224319740

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224319740&repo=mozilla-inbound&lineNumber=41090

Comment 6

[Tom Ritter [:tjr]]

Attachment: Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

Whoops. This new patch should fix it.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b975d4b8f3a3c5737bc4271c426c23e41cdf1950

Comment 7

[Mike Hommey [:glandium]]

We should also remove https://searchfox.org/mozilla-central/rev/4faab2f1b697827b93e16cb798b22b197e5235c9/build/moz.configure/bindgen.configure#328

Comment 8

[Tom Ritter [:tjr]]

Attachment: Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70be90ca708619e370ec514bb334239890f3637d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c373e34039b
Remove the force-ms-compatibility for clang-cl r=glandium

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9c373e34039b

Comment 11

[Tom Ritter [:tjr]]

Comment on attachment 9039810 [details] [diff] [review]
Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

We won't be able to land a security improvement in Bug 1485016

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This is a build configuration change

String changes made/needed

Comment 12

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9039810 [details] [diff] [review]
Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

OK for beta uplift - this patch in bug 1523003 first, then the patch in bug 1485016, then in bug 1525588.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe8f0e01fc95