Remove the force-ms-compatibility for clang-cl

RESOLVED FIXED in Firefox 66

Status

defect
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

Trunk
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed, firefox67 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Assignee

Description

4 months ago
No description provided.
Assignee

Updated

4 months ago
Attachment #9039255 - Attachment is patch: true
Assignee

Comment 2

4 months ago
Attachment #9039255 - Attachment is obsolete: true
Attachment #9039255 - Flags: review?(mh+mozilla)
Attachment #9039255 - Flags: review?(dmajor)
Attachment #9039314 - Flags: review?(mh+mozilla)
Assignee

Updated

4 months ago
Summary: Remove the force-ms-compatibility for clang-cl and change the clang-cl version number to reflect clang's version → Remove the force-ms-compatibility for clang-cl
Attachment #9039314 - Flags: review?(mh+mozilla) → review+
Assignee

Updated

4 months ago
Keywords: checkin-needed
Assignee

Comment 3

4 months ago

If any issues arise from this; please ni glandium :)

Comment 4

4 months ago

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/579d66b2e57d
Remove the force-ms-compatibility for clang-cl. r=glandium

Keywords: checkin-needed
Attachment #9039810 - Flags: review?(mh+mozilla) → review+
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 9

4 months ago

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c373e34039b
Remove the force-ms-compatibility for clang-cl r=glandium

Keywords: checkin-needed

Comment 10

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee

Comment 11

4 months ago

Comment on attachment 9039810 [details] [diff] [review]
Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

We won't be able to land a security improvement in Bug 1485016

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This is a build configuration change

String changes made/needed

Attachment #9039810 - Flags: approval-mozilla-beta?
Comment on attachment 9039810 [details] [diff] [review]
Bug 1523003 - Remove the force-ms-compatibility for clang-cl r?glandium

OK for beta uplift - this patch in bug 1523003 first, then the patch in bug 1485016, then in bug 1525588.
Attachment #9039810 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.