Closed
Bug 1523031
Opened 5 years ago
Closed 5 years ago
Hero with lists show 1 too many items
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
(Keywords: github-merged)
User Story
QA steps: use dev-test-all and for the 2/3 and 1/3 Hero components, they should have one large and 4 smaller List styled items (fyi the wide Hero has cards for additional items and were unchanged)
Attachments
(2 files)
QA Results : Bug - 1523031.png
Hero with 5 items in 2/3 or 1/3 should show 1 hero and 4 list items
|
||
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/7a5e9d4b52804bdfb96bf18a7fedebc7b4b26411 Bug 1523031 - Hero with lists show 1 too many items (#4739)
|
||
Updated•5 years ago
|
Keywords: github-merged
|
Assignee | |
Updated•5 years ago
|
User Story: (updated)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 4•5 years ago
|
||
QA Results:
Tested on :
FF Nightly version : 67.0a1 (2019-02-05)
OS : Mac and Windows 10 Pro
Results attached QA Results : Bug - 1523031.png
(Recording) - https://www.dropbox.com/s/5i1cn8oh5heigin/QA%20Results%20%28Rec%29%20%3A%20Bug%20-%201523031.mp4?dl=0
Closing as verified.
|
|
||
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•