Options tab: Panes can't be switched - TypeError: control.radioChildConstructed is not a function radio.xml:29:13 - Mozmill failures on 2019-01-26: cloudfile/test-cloudfile-manager.js, pref-window/test-font-chooser.js, mozmill/testAlarmDefaultValue.js
Categories
(Thunderbird :: Preferences, defect)
Tracking
(Not tracked)
People
(Reporter: Paenglab, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [Thunderbird-testfailure: Z all][Thunderbird-disabled-test][fixed by bug 1522778])
Attachments
(1 file)
3.76 KB,
patch
|
Details | Diff | Splinter Review |
When opening the prefs I get:
TypeError: control.radioChildConstructed is not a function radio.xml:29:13
radio_XBL_Constructor chrome://global/content/bindings/radio.xml:29
_insertElement resource:///modules/Overlays.jsm:372
_mergeElement resource:///modules/Overlays.jsm:408
_resolveForwardReference resource:///modules/Overlays.jsm:320
load resource:///modules/Overlays.jsm:158
load resource:///modules/Overlays.jsm:40
observe chrome://messenger/content/parent/ext-legacy.js:138
TypeError: child is null[Learn More] customElements.js:80:7
The build from Fri, Jan 25, 23:22:31 is working but the Daily from today not.
Last good: https://hg.mozilla.org/mozilla-central/rev/e4b9b1084292
First bad: https://hg.mozilla.org/mozilla-central/rev/341040a5fb80
Comment 1•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4b9b1084292&tochange=341040a5fb80
Hmm, it's easy to blame it on M-C, but sometimes we have caused regressions ourselves. Can you try a backout of
https://hg.mozilla.org/comm-central/rev/bffe1c0bac89d31eb8154176efbe27ef11aab997
Anyway, this is CE/de-XBL territory.
Reporter | ||
Comment 3•5 years ago
|
||
I'll try, but why is a build from Fri, Jan 25, 23:22:31 working? It has this change already?
Comment 4•5 years ago
|
||
Yes, bug 1509732, but now something else broke apparently.
Comment 5•5 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #3)
I'll try, but why is a build from Fri, Jan 25, 23:22:31 working? It has this change already?
Just ignore me ;-)
Reporter | ||
Comment 6•5 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #1)
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4b9b1084292&tochange=341040a5fb80
Hmm, it's easy to blame it on M-C, but sometimes we have caused regressions ourselves. Can you try a backout of
https://hg.mozilla.org/comm-central/rev/bffe1c0bac89d31eb8154176efbe27ef11aab997
For the record: A backout didn't help.
Comment 7•5 years ago
|
||
So you ignored to ignore me? ;-)
I guess this accounts for these test failures:
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1548498549/build/tests/mozmill/cloudfile/test-cloudfile-manager.js | test-cloudfile-manager.js::test_external_link
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1548498760/build/tests/mozmill/pref-window/test-font-chooser.js | test-font-chooser.js::test_font_name_displayed
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1548498760/build/tests/mozmill/pref-window/test-font-chooser.js | test-font-chooser.js::test_font_name_not_present
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1548498760/build/tests/mozmill/testAlarmDefaultValue.js | testAlarmDefaultValue.js::testDefaultAlarms
Maybe Aceman can take a look.
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Comment 8•5 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #7)
So you ignored to ignore me? ;-)
No, your comment to ignore came too late.
It is choking on this radiogroup in prefs:
https://searchfox.org/comm-central/source/mail/components/preferences/aboutPreferences.xml#28
Comment 10•5 years ago
|
||
So CustomElements business as usual. The XBL code of "radio" (https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets/radio.xml#28) is run before the parent radiogroup is 'constructed' and 'connected' in https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets/radio.js#11 .
Reporter | ||
Comment 11•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ae7ae0acee4 regresses this.
Comment 12•5 years ago
|
||
Thanks Richard, I've confirmed the regression via local backout (quite painful since a large recompile is triggered).
Comment 13•5 years ago
|
||
Sorry! I'm not sure how or why that would regress anything for you. I'm happy to assist where I can but I don't see any correlation tbh. Especially in the XUL scenario it should not affect anything.
Reporter | ||
Comment 14•5 years ago
|
||
Zibi, we use fluent too in our prefs.
When I remove this block https://searchfox.org/comm-central/source/mail/components/preferences/aboutPreferences.xul#39-42 then I can switch the panes again.
Comment 15•5 years ago
|
||
Well, I assume that FF options still work, so this may be related to the fact that we still haven't addressed bug 1468167 :-(
Comment 16•5 years ago
|
||
All tests relate to the pref tab somehow.
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Richard: that's ok. My patch show work for all and any xul/xhtml/HTML using Fluent in Gecko. If it doesn't , something is wrong and I don't know what.
Comment 18•5 years ago
|
||
(In reply to :aceman from comment #10)
The XBL code of "radio" (https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets/radio.xml#28) is run before the parent radiogroup is 'constructed' and 'connected' in https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets/radio.js#11 .
Confirming.
After reverting m-c to before https://hg.mozilla.org/mozilla-central/rev/9ae7ae0acee4 the ordering is better:
- constructor of radiogroup
- constructor of radio
- connectedCallback of radiogroup (CE)
This still isn't the best, but at least the function radioChildConstructed() is already bound to the radiogroup element and exists.
Comment 19•5 years ago
|
||
By coincidence, I've been working on a patch for bug 1522778 which passes these tests. It needs a lot of cleanup which I'll do tonight or tomorrow.
Comment 20•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/63b3267ac3ba
temporarily switch off failing tests that open the preferences/options tab. rs=bustage-fix DONTBUILD
Comment 21•5 years ago
|
||
I accidentally closed this, but let's leave it closed and assume it will be fixed in bug 1522778.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 22•5 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/7c77797f78ec (Partly) backed out changeset 63b3267ac3ba to re-enable tests (see bug 1524450 for remaining disabled test). a=backout
Comment 23•5 years ago
|
||
TB 66 beta:
https://hg.mozilla.org/releases/comm-beta/rev/fe791ff3dc62
This is a complete backout of rev 63b3267ac3ba from TB 66 beta since it's not affected by bug 1524450.
Description
•