Closed Bug 1523081 Opened 1 year ago Closed 1 year ago

Bustages on /src/js/src/wasm/WasmTextToBinary.cpp when Gecko 66 merges to beta on 2019-01-21

Categories

(Core :: Javascript: WebAssembly, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
thunderbird_esr60 --- unaffected
geckoview64 --- unaffected
geckoview65 --- unaffected
geckoview66 --- unaffected
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 --- fixed

People

(Reporter: rmaries, Assigned: aryx)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=3ba6c0e2814d5e11893691f712bff0cac4225323&selectedJob=224197952

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224197952&repo=try&lineNumber=12808

[task 2019-01-26T11:07:55.707Z] 11:07:55 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/js/src/wasm/Unified_cpp_js_src_wasm3.cpp:2:
[task 2019-01-26T11:07:55.707Z] 11:07:55 ERROR - /builds/worker/workspace/build/src/js/src/wasm/WasmTextToBinary.cpp:994:39: error: no member named 'DataCount' in '(anonymous namespace)::WasmToken'
[task 2019-01-26T11:07:55.707Z] 11:07:55 INFO - return WasmToken(WasmToken::DataCount, begin, cur_);
[task 2019-01-26T11:07:55.708Z] 11:07:55 INFO - ~~~~~~~~~~~^
[task 2019-01-26T11:07:55.708Z] 11:07:55 ERROR - /builds/worker/workspace/build/src/js/src/wasm/WasmTextToBinary.cpp:997:39: error: no member named 'DataDrop' in '(anonymous namespace)::WasmToken'
[task 2019-01-26T11:07:55.708Z] 11:07:55 INFO - return WasmToken(WasmToken::DataDrop, begin, cur_);
[task 2019-01-26T11:07:55.711Z] 11:07:55 INFO - ~~~~~~~~~~~^
[task 2019-01-26T11:07:55.711Z] 11:07:55 ERROR - /builds/worker/workspace/build/src/js/src/wasm/WasmTextToBinary.cpp:1009:39: error: no member named 'ElemDrop' in '(anonymous namespace)::WasmToken'
[task 2019-01-26T11:07:55.711Z] 11:07:55 INFO - return WasmToken(WasmToken::ElemDrop, begin, cur_);
[task 2019-01-26T11:07:55.711Z] 11:07:55 INFO - ~~~~~~~~~~~^
[task 2019-01-26T11:07:55.711Z] 11:07:55 INFO - 3 errors generated.
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - /builds/worker/workspace/build/src/config/rules.mk:1106: recipe for target 'Unified_cpp_js_src_wasm3.o' failed
[task 2019-01-26T11:07:55.712Z] 11:07:55 ERROR - make[4]: *** [Unified_cpp_js_src_wasm3.o] Error 1
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/wasm'
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - js/src/Unified_cpp_js_src15.o
[task 2019-01-26T11:07:55.712Z] 11:07:55 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-01-26T11:07:56.759Z] 11:07:56 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/security/sandbox/linux/gtest'

We ran two other beta sims while trying to figure out what bug is causing this failure and ended up backing out all bugs that touched the file plus an additional one that was causing a conflict for the last bug we tried to backout.

The bugs are: 1502035, 1513499, 1522082, 1522081, 1521780 (for causing conflicts on passive-segs-boundary.js), 1502037

Lars please take a look.

Flags: needinfo?(lhansen)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/2bad68e1de18
ifdef all of wasm DataCount, DataDrop and ElemDrop to fix bustage if ENABLE_WASM_BULKMEM_OPS is not set r=arai
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

:arai to the rescue once again, I guess :)

Flags: needinfo?(lhansen)
Assignee: nobody → aryx.bugmail
You need to log in before you can comment on or make changes to this bug.