1523109 - Port bug 1522694: Add an API to get whether this install is the OS default install

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

Looks like toolkit tests will soon use nsIToolkitShellService.isDefaultApplication declared here:
https://hg.mozilla.org/mozilla-central/rev/98859fd44b41#l12.21

If we don't provide it, those tests will fail.

Looks like the changeset would be easy to port since we already have ns*ShellService.cpp here:
https://searchfox.org/comm-central/source/mail/components/shell

Comment 1

[Jorg K (CEST = GMT+2)]

Maybe bug 1521902 is also worth a look in this context. I haven't looked, FRG mentioned it on IRC.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1523109-isDefaultApplication.patch

This compile on Windows. I left the aStartupCheck parameter since it's uses a few times.

This should compile in the other platforms as well, Magnus can you check on Linux.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1523109-isDefaultApplication.patch (v1b)

Changed variable name, sorry about the noise.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9039430 [details] [diff] [review]
1523109-isDefaultApplication.patch (v1b)

Review of attachment 9039430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=mkmelin

::: mail/components/shell/nsToolkitShellService.h
@@ +14,5 @@
> +                             uint16_t aApps,
> +                             bool* aIsDefaultClient) = 0;
> +
> +  NS_IMETHODIMP IsDefaultApplication(bool* aIsDefaultClient) {
> +    // Only care about the http(s) protocol. This only matters on Windows.

This looks like the case for Firefox. I assume we're after the mailto protocol

Comment 5

[Jorg K (CEST = GMT+2)]

Right, cut/paste error, will fix before landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e1c6a32b962
Port bug 1522694: Add support for nsIToolkitShellService.isDefaultApplication(). r=mkmelin