1523134 - Inconsistent color painting

Status: NEW

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: newline.html

The testcase is a copy of https://searchfox.org/mozilla-central/source/layout/reftests/first-line/restyle-inside-first-line.html

'This' is either black or purple. As far as I see, it should be always purple.

While changing RefreshDriver scheduling, the reftest starts to fail randomly, but based on the testcase the issue is already in Nightly.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Style system issue involving first-line...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

(In reply to Xidorn Quan [:xidorn] UTC+11 from comment #1)

Style system issue involving first-line...

This seems more of a painting issue, since switching tabs back and forth fixes it (at least here with WebRender enabled)...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Guess I shouldn't prioritize Web Painting bugs.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: test-case that always shows black.

Adding a layout flush after the style change makes it consistently wrong here...

So maybe a style system issue after all.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

FWIW, I don't have web render enabled.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Huh, or not, since even in that test-case it shows purple when selecting and de-selecting the text, which shouldn't cause any restyling to happen... Weird

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Selecting and de-selecting can trigger ::selection to apply I suppose? But yeah probably no restyling there...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

So this did regress with stylo, probably: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f64e2b4dcf5eec0b4ad456c149680a67b7c26dc4&tochange=93dd2e456c0ecca00fb4d28744e88078a77deaf7

But I think the problem may be still somewhere else.