Explicitly wait for the localized buttons before sizing the window to content

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed, firefox67 fixed)

Details

Attachments

(1 attachment)

Bug 1523126 attempted to size the dialog in the next paint, but in some situations we dialogs we don't appear to have all of the strings localized in the first paint.

The attached patch will explicitly wait for the localized buttons to get translated before sizing the dialog.

Component: General → XUL Widgets
Product: Firefox → Toolkit

After more investigations we determined that the dialog being cut off was related to non-integer DPI displays and are unrelated to Fluent. I'm going to land this patch however since it is more semantically correct than what we currently have in the tree. In the event that we need to use fallback languages it can take more than a single animation frame before we can localize the content.

I'll file a different bug for the dialog not sized correctly with 125% DPI.

Summary: Reset Profile (Refresh Firefox) dialog has buttons cut off on the bottom → Explicitly wait for the localized buttons before sizing the window to content
Component: XUL Widgets → Localization
Product: Toolkit → Core
Component: Localization → XUL Widgets
Product: Core → Toolkit

Comment 3

5 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41293fa5d3ef
Explicitly wait for the localized buttons before sizing the window to content. r=mconley

Comment 4

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Does this need an uplift request?

Flags: needinfo?(jaws)

Comment on attachment 9039408 [details]
Bug 1523166 - Explicitly wait for the localized buttons before sizing the window to content. r?mconley

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1523126

User impact if declined

This is a follow-on patch to bug 1523126. We are unaware of bugs that this patch is fixing, though we know of a potential issue that this patch fixes. See below for description.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The prior behavior was to wait for an animation frame before resizing the dialog. In the event of fallback languages it may take more than a single animation frame before we can resize the dialog. This patch is thus more semantically correct and should work in more situations than the prior behavior.

String changes made/needed

none

Flags: needinfo?(jaws)
Attachment #9039408 - Flags: approval-mozilla-beta?

Comment on attachment 9039408 [details]
Bug 1523166 - Explicitly wait for the localized buttons before sizing the window to content. r?mconley

Additional patch for the fix for safe mode restart text layout.
OK for uplift for beta 7.

Attachment #9039408 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.