1523166 - Explicitly wait for the localized buttons before sizing the window to content

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1523126 attempted to size the dialog in the next paint, but in some situations we dialogs we don't appear to have all of the strings localized in the first paint.

The attached patch will explicitly wait for the localized buttons to get translated before sizing the dialog.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1523166 - Explicitly wait for the localized buttons before sizing the window to content. r?mconley

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

After more investigations we determined that the dialog being cut off was related to non-integer DPI displays and are unrelated to Fluent. I'm going to land this patch however since it is more semantically correct than what we currently have in the tree. In the event that we need to use fallback languages it can take more than a single animation frame before we can localize the content.

I'll file a different bug for the dialog not sized correctly with 125% DPI.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41293fa5d3ef
Explicitly wait for the localized buttons before sizing the window to content. r=mconley

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/41293fa5d3ef

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does this need an uplift request?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9039408 [details]
Bug 1523166 - Explicitly wait for the localized buttons before sizing the window to content. r?mconley

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1523126

User impact if declined

This is a follow-on patch to bug 1523126. We are unaware of bugs that this patch is fixing, though we know of a potential issue that this patch fixes. See below for description.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

The prior behavior was to wait for an animation frame before resizing the dialog. In the event of fallback languages it may take more than a single animation frame before we can resize the dialog. This patch is thus more semantically correct and should work in more situations than the prior behavior.

String changes made/needed

none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9039408 [details]
Bug 1523166 - Explicitly wait for the localized buttons before sizing the window to content. r?mconley

Additional patch for the fix for safe mode restart text layout.
OK for uplift for beta 7.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/546e05b0e3d2