Closed Bug 1523175 Opened 2 years ago Closed 1 year ago

Upgrade Firefox 67 to use NSS 3.43

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: jcj, Assigned: jcj)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(2 files, 1 obsolete file)

Tracking NSS 3.43 for Firefox 67.

Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c347507b88c
land NSS d0a282507d59 UPGRADE_NSS_RELEASE, r=me
Depends on: 1526010

require new NSPR 4.21

Attachment #9042418 - Flags: review?(jjones)
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eee8ce2afe60
land NSS 794984bb1169 UPGRADE_NSS_RELEASE, r=me
Attachment #9042418 - Flags: review?(jjones) → review+
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac41d41f0494
land NSS b7713856ebf2 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/395ba4512e92
land NSS 1f04eea8834a UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13b6c8c4ab74
land NSS f7be0a534e89 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e4d951c88fd
land NSS 536fd7c9db5a UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f84b1b428d42
land NSS a306d84e4c70 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d652c07b0c04
land NSS NSS_3_43_BETA1 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71aaa0c1b7d8
land NSS NSS_3_43_BETA2 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d57a9605a6d1
land NSS NSS_3_43_BETA3 UPGRADE_NSS_RELEASE, r=me
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3b62757bd38
land NSS NSS_3_43_BETA4 UPGRADE_NSS_RELEASE, r=me
Depends on: 1535826
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f02ab9dc45a7
land NSS NSS_3_43_RTM UPGRADE_NSS_RELEASE, r=me
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached patch nss-version-fix (obsolete) — Splinter Review

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: n/a
  • User impact if declined: potential build errors. We/I forgot to bump the nss version number in the old-configure.in to 3.43 from 3.42 for beta.

See beta:
https://hg.mozilla.org/releases/mozilla-beta/file/tip/old-configure.in#l1547
Compare to current release:
https://hg.mozilla.org/releases/mozilla-release/file/tip/old-configure.in#l1634
Compare to m-c:
https://hg.mozilla.org/mozilla-central/file/tip/old-configure.in#l1541

  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a configure script. Building outside of m-c, we require the prior version of NSS. We should require the correct one.
  • String changes made/needed: none
Attachment #9055495 - Flags: approval-mozilla-beta?
Comment on attachment 9042418 [details] [diff] [review]
nspr-version.patch

huh. Attachment 9042418 [details] [diff] does not need uplift to beta. Only the new attachment. Bugzilla bug.
Attachment #9042418 - Flags: approval-mozilla-beta?

(In reply to J.C. Jones [:jcj] (he/him) from comment #27)

Created attachment 9055495 [details] [diff] [review]
nss-version-fix

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: n/a
  • User impact if declined: potential build errors. We/I forgot to bump the nss version number in the old-configure.in to 3.43 from 3.42 for beta.

Thez attached file is a search/replace command, I think you wanted to attach the result of this command as a patch, right?

Flags: needinfo?(jjones)

(In reply to Pascal Chevrel:pascalc from comment #29)

(In reply to J.C. Jones [:jcj] (he/him) from comment #27)

Created attachment 9055495 [details] [diff] [review]
nss-version-fix

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: n/a
  • User impact if declined: potential build errors. We/I forgot to bump the nss version number in the old-configure.in to 3.43 from 3.42 for beta.

Thez attached file is a search/replace command, I think you wanted to attach the result of this command as a patch, right?

I can. Usually on NSS upgradey-sorts-of-things-for-beta, we provide a script.

I'll go make the patch for this one though.

Flags: needinfo?(jjones)

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: as above
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9055495 - Attachment is obsolete: true
Attachment #9055495 - Flags: approval-mozilla-beta?
Attachment #9055597 - Flags: approval-mozilla-beta?
Attachment #9042418 - Flags: approval-mozilla-beta?
Attachment #9055495 - Flags: approval-mozilla-beta?
Comment on attachment 9042418 [details] [diff] [review]
nspr-version.patch

again, this is _not_ being asked for uplift... (It's already there) ... silly Bugzilla
Attachment #9042418 - Flags: approval-mozilla-beta?
Comment on attachment 9055597 [details] [diff] [review]
nss-version-fix.patch

Update NSS version in build script, low risk patch with tests, approved for 67 beta 9, thanks.
Attachment #9055597 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9055495 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.