WIN_DIA_SDK_BIN_DIR shouldn't have to be set manually

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

5 months ago

Worse than having to be set manually, it also has to be added to PATH manually.

Assignee

Updated

5 months ago
Summary: WIN_DIA_SDK_BIN_DIR shouldn't be have to be set manually → WIN_DIA_SDK_BIN_DIR shouldn't have to be set manually
Assignee

Comment 1

5 months ago

We can't run dump_syms without the DIA SDK binary directory in $PATH
because dump_syms requires the DIA dll from there.

Obviously, the corresponding test can't run if the DIA SDK binary
directory is not known (rather than when the dia2.h header is not found,
since the build system currently relies on WIN_DIA_SDK_BIN_DIR being
given manually).

Assignee

Comment 2

5 months ago

We currently rely on WIN_DIA_SDK_BIN_DIR being passed, but we can
actually derive it from the DIA SDK directory. So we now do that, except
when it's given explicitly.

While in the vicinity, move the dia2.h check to python configure.

With WIN_DIA_SDK_BIN_DIR being derived and not set when dia2.h is not
found, we don't really need MSVC_HAS_DIA_SDK anymore, so we just check
for WIN_DIA_SDK_BIN_DIR to determine whether to build dump_syms or not.

One exception to the above is when WIN_DIA_SDK_BIN_DIR is passed in,
which we only keep for the in-tree mozconfigs for now. We'll remove that
possibility after bug 1523198.

Depends on D17892

Comment 3

5 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/52e639ef67df
Automatically add WIN_DIA_SDK_BIN_DIR to PATH when running dump_syms. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/d0335e34cb16
Streamline the DIA SDK setup. r=chmanchester
Assignee

Updated

5 months ago
Blocks: 1523537

Comment 4

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.