1523204 - WIN_DIA_SDK_BIN_DIR shouldn't have to be set manually

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Worse than having to be set manually, it also has to be added to PATH manually.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1523204 - Automatically add WIN_DIA_SDK_BIN_DIR to PATH when running dump_syms.

We can't run dump_syms without the DIA SDK binary directory in $PATH
because dump_syms requires the DIA dll from there.

Obviously, the corresponding test can't run if the DIA SDK binary
directory is not known (rather than when the dia2.h header is not found,
since the build system currently relies on WIN_DIA_SDK_BIN_DIR being
given manually).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1523204 - Streamline the DIA SDK setup.

We currently rely on WIN_DIA_SDK_BIN_DIR being passed, but we can
actually derive it from the DIA SDK directory. So we now do that, except
when it's given explicitly.

While in the vicinity, move the dia2.h check to python configure.

With WIN_DIA_SDK_BIN_DIR being derived and not set when dia2.h is not
found, we don't really need MSVC_HAS_DIA_SDK anymore, so we just check
for WIN_DIA_SDK_BIN_DIR to determine whether to build dump_syms or not.

One exception to the above is when WIN_DIA_SDK_BIN_DIR is passed in,
which we only keep for the in-tree mozconfigs for now. We'll remove that
possibility after bug 1523198.

Depends on D17892

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e639ef67df
Automatically add WIN_DIA_SDK_BIN_DIR to PATH when running dump_syms. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/d0335e34cb16
Streamline the DIA SDK setup. r=chmanchester

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/52e639ef67df
https://hg.mozilla.org/mozilla-central/rev/d0335e34cb16