Font editor: show read-only properties for pseudo-elements
Categories
(DevTools :: Inspector, enhancement, P1)
Tracking
(firefox66 fixed, firefox67 fixed)
People
(Reporter: rcaliman, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
(Whiteboard: [dt-q])
Attachments
(2 files)
28.05 KB,
image/jpeg
|
Details | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
The Font Editor writes property value changes to an element's inline style. This is done to ensure the "what you see is what you get" user expectation when editing a property value regardless of its origin within the CSS cascade.
Pseudo-elements do not have an inline style that can be written to. The simple solution is to treat them in the Font Editor as unsupported element types, like comment nodes.
However, pseudo-elements may have font properties attached. Their use with icon fonts is a notable use case. Users want to be able to at least inspect the fonts and font properties applied to the selected pseudo-element.
We should provide this information for pseudo-elements in the Font Editor in a read-only mode (and include a note) until we implement a way to write value changes to individual CSS style rules instead of element inline styles.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6059b2434214 Show Font Editor in read-only mode for pseudo-elements. r=gl
Assignee | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Comment on attachment 9040760 [details]
Bug 1523305 - Show Font Editor in read-only mode for pseudo-elements. r=gl
We need this on beta along with bug 1526054.
Comment 5•5 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Description
•