1523330 - Compare subtest view error

Status: VERIFIED FIXED

(Tree Management :: Perfherder, defect, P2)

Description

[Ionuț Goldan [:igoldan]]

When going to this link: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-inbound&newProject=mozilla-inbound&originalSignature=1825334&newSignature=1825334&framework=10

Comment 1

[Sarah Clements [:sclements]]

This is failing because the newRevision query parameter is missing. The existing query parameter validation doesn't have error handling built in (which will be addressed during the course of the conversion). You can see in the network tab that the resultset url is missing the revision query param (https://treeherder.mozilla.org/api/project/mozilla-inbound/resultset/?full=true&count=10&revision=undefined) so it's not returning data that is later relied upon.

Did you type these params in manually or was this link generated from somewhere else in TH or Perfherder?

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #1)

Did you type these params in manually or was this link generated from somewhere else in TH or Perfherder?

Dave, can you say where the URL is from?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #2)

(In reply to Sarah Clements [:sclements] from comment #1)

Did you type these params in manually or was this link generated from somewhere else in TH or Perfherder?

Dave, can you say where the URL is from?

It was the 'subtests' link from any of the alerts in https://treeherder.mozilla.org/perf.html#/alerts?id=18959 I think at the time I was interested in the "raptor-tp6-microsoft-firefox osx-10-10 opt" alert, but others appear to be affected.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Screenshot 2019-01-30 at 13.42.33.png

Comment 5

[Sarah Clements [:sclements]]

It looks like there might be a problem with the logic used to generate the subtests url for the alerts here: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/helpers.js#L383

Comment 6

[Sarah Clements [:sclements]]

This issue has been fixed with the recent alerts conversion pr: https://github.com/mozilla/treeherder/commit/cfde588e43800b6d137b42b11fd91294a3bfe8ca