Closed Bug 1523332 Opened 2 years ago Closed 2 years ago

Check if QuantumBar can work with a pref flip study (and fix if not)

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1523332 - Allow to instant switch on and off the Quantum Bar. r=dao!
47 bytes, text/x-phabricator-request
Details | Review

We are planning on doing a pref-flip roll-out for QuantumBar on nightly.

Whilst we know that changing the pref & restarting works fine, we need to be able to cope with a pref flip happening at almost any time - e.g. do we still work fine if a new window is opened after the pref flip?

We might need to check how @supports -moz-bool-pref("browser.urlbar.quantumbar") with respect the other places that we check the QuantumBar pref.

Blocks: 1521838

I'll start investigating this

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Blocks: 1521495

So, this is not trivial because of bindings, most of the times something is broken (like opening a new window after flipping the pref), I have a patch that works, but it's not the nicest.
Anyway it's worth starting the discussion/investigation, so I'll attach it and we'll go from there.

Blocks: 1526374
Blocks: 1531062
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/7b3e30ae92a9
Allow to instant switch on and off the Quantum Bar. r=dao

https://hg.mozilla.org/mozilla-central/rev/7b3e30ae92a9

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.