Closed
Bug 1523335
Opened 6 years ago
Closed 6 years ago
Make use of parentFlexElement in Flexbox inspector (server and client)
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file)
Search for function findFlexOrGridParentContainerForNode
and most of those methods would be much more performant if they made use of getFlexParent()
.
Assignee | ||
Updated•6 years ago
|
Component: CSS Parsing and Computation → Inspector
Product: Core → DevTools
Assignee | ||
Updated•6 years ago
|
Summary: Make use of getFlexParent() in Flexbox inspector (server and client) → Make use of parentFlexElement in Flexbox inspector (server and client)
Assignee | ||
Comment 1•6 years ago
|
||
This gives a very noticeable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use parentFlexElement
and parentGridElement
.
Comment 2•6 years ago
|
||
Backed out for devtools failures on browser_rules_gridline-names-autocomplete.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226242381&repo=autoland&lineNumber=2278
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226242443&repo=autoland&lineNumber=3918
Backout link: https://hg.mozilla.org/integration/autoland/rev/351ce9eb16591c088e558761be1ebb3f195dbfa5
Flags: needinfo?(mratcliffe)
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdef8bbcf493
Make use of parentFlexElement in Flexbox inspector r=pbro
Comment 5•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mratcliffe)
You need to log in
before you can comment on or make changes to this bug.
Description
•