Make use of parentFlexElement in Flexbox inspector (server and client)

RESOLVED FIXED in Firefox 67

Status

enhancement
P2
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: miker, Assigned: miker)

Tracking

unspecified
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Search for function findFlexOrGridParentContainerForNode and most of those methods would be much more performant if they made use of getFlexParent().

Component: CSS Parsing and Computation → Inspector
Product: Core → DevTools
Summary: Make use of getFlexParent() in Flexbox inspector (server and client) → Make use of parentFlexElement in Flexbox inspector (server and client)

This gives a very noticeable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use parentFlexElement and parentGridElement.

Comment 4

5 months ago
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdef8bbcf493
Make use of parentFlexElement in Flexbox inspector r=pbro

Comment 5

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: needinfo?(mratcliffe)
You need to log in before you can comment on or make changes to this bug.