1523335 - Make use of parentFlexElement in Flexbox inspector (server and client)

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Search for function findFlexOrGridParentContainerForNode and most of those methods would be much more performant if they made use of getFlexParent().

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1523335 - Make use of parentFlexElement in Flexbox inspector r?pbro!

This gives a very noticeable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use parentFlexElement and parentGridElement.

Comment 2

[Cosmin Sabou [:CosminS]]

Backed out for devtools failures on browser_rules_gridline-names-autocomplete.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8a5155bd8809ad8e6ab3aeb3679be53b22aec66d&searchStr=chrome&selectedJob=226242381

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226242381&repo=autoland&lineNumber=2278
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226242443&repo=autoland&lineNumber=3918

Backout link: https://hg.mozilla.org/integration/autoland/rev/351ce9eb16591c088e558761be1ebb3f195dbfa5

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e2f205a759c926cf85703a5e1f7427586f7ac75

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdef8bbcf493
Make use of parentFlexElement in Flexbox inspector r=pbro

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/bdef8bbcf493