Closed Bug 1523340 Opened 5 years ago Closed 5 years ago

12,800 instances of "'NS_FAILED(rv)'" emitted from xpcom/base/MemoryTelemetry.cpp during linux64 debug testing

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1523340 - Reduce scope of memory telemetry warning. r=kmag
47 bytes, text/x-phabricator-request
Details | Review

12780 WARNING: 'NS_FAILED(rv)', file xpcom/base/MemoryTelemetry.cpp, line 304

This warning [1] shows up in the following test suites:

   300 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   300 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   251 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   251 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   152 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
   152 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
   150 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
   150 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
   148 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
   148 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
   144 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
   144 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
   140 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
   140 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
   140 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
   140 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
   140 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
   140 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
   138 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
   138 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
   138 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
   138 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
   130 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
   130 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
   130 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
   130 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
   128 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
   128 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
   126 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
   126 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
   126 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
   126 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
   122 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
   122 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
   120 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
   120 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
   118 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
   118 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
   108 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   108 - test-linux64/debug-reftest-sw-e10s-1 R1
   108 - test-linux64/debug-reftest-e10s-1 R1
   108 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   106 - test-linux64/debug-reftest-e10s-7 R7
   106 - test-linux64/debug-reftest-e10s-5 R5
   106 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
   106 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   106 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   106 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
   106 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   106 - test-linux64/debug-reftest-sw-e10s-7 R7
   106 - test-linux64/debug-reftest-e10s-6 R6
   106 - test-linux64/debug-reftest-sw-e10s-3 R3
   106 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   106 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   106 - test-linux64/debug-reftest-e10s-3 R3
   106 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   106 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   106 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   106 - test-linux64/debug-reftest-sw-e10s-5 R5
   106 - test-linux64/debug-reftest-sw-e10s-6 R6
   100 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   100 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   100 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   100 - test-linux64/debug-reftest-sw-e10s-4 R4
   100 - test-linux64/debug-reftest-e10s-4 R4
   100 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
    92 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
    92 - test-linux64/debug-reftest-e10s-2 R2
    92 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
    92 - test-linux64/debug-reftest-sw-e10s-2 R2
    84 - test-linux64/debug-mochitest-chrome-sw-1 c1
    84 - test-linux64/debug-mochitest-chrome-1 c1
    82 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-6 Wr6
    82 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
    82 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
    82 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
    82 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
    82 - test-linux64/debug-mochitest-chrome-sw-2 c2
    82 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
    82 - test-linux64/debug-mochitest-chrome-2 c2
    82 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-5 Wr5
    82 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
    78 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
    78 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
    66 - test-linux64/debug-mochitest-chrome-sw-3 c3
    66 - test-linux64/debug-mochitest-chrome-3 c3
    65 - test-linux64/debug-marionette-headless-e10s MnH
    65 - test-linux64/debug-marionette-e10s Mn
    64 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
    64 - test-linux64/debug-mochitest-clipboard-e10s cl
    32 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
    32 - test-linux64/debug-mochitest-plain-headless-sw-e10s-15 h15
    32 - test-linux64/debug-mochitest-sw-e10s-15 15
    31 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
    31 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
    31 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
    30 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
    30 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
    30 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
    30 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
    30 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
    30 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
    30 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
    30 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
    30 - test-linux64/debug-mochitest-e10s-15 15
    30 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
    28 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
    28 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
    28 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
    28 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
    28 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
    28 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
    26 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
    26 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
    24 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
    24 - test-linux64/debug-mochitest-e10s-8 8
    22 - test-linux64/debug-mochitest-sw-e10s-8 8
    22 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
    22 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
    22 - test-linux64/debug-mochitest-sw-e10s-5 5
    22 - test-linux64/debug-mochitest-plain-headless-sw-e10s-11 h11
    22 - test-linux64/debug-mochitest-sw-e10s-1 1
    22 - test-linux64/debug-mochitest-plain-headless-sw-e10s-4 h4
    22 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
    22 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
    22 - test-linux64/debug-mochitest-e10s-5 5
    22 - test-linux64/debug-mochitest-e10s-1 1
    22 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
    22 - test-linux64/debug-mochitest-sw-e10s-11 11
    22 - test-linux64/debug-mochitest-sw-e10s-9 9
    20 - test-linux64/debug-mochitest-e10s-11 11
    20 - test-linux64/debug-mochitest-plain-headless-sw-e10s-5 h5
    20 - test-linux64/debug-mochitest-sw-e10s-7 7
    20 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
    20 - test-linux64/debug-mochitest-e10s-9 9
    20 - test-linux64/debug-mochitest-plain-headless-sw-e10s-6 h6
    20 - test-linux64/debug-mochitest-e10s-3 3
    20 - test-linux64/debug-mochitest-sw-e10s-4 4
    20 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
    20 - test-linux64/debug-mochitest-e10s-16 16
    20 - test-linux64/debug-mochitest-e10s-4 4
    20 - test-linux64/debug-mochitest-e10s-14 14
    20 - test-linux64/debug-mochitest-sw-e10s-3 3
    20 - test-linux64/debug-mochitest-plain-headless-sw-e10s-1 h1
    20 - test-linux64/debug-mochitest-e10s-7 7
    20 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
    20 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    20 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
    20 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    20 - test-linux64/debug-mochitest-e10s-10 10
    18 - test-linux64/debug-mochitest-e10s-6 6
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-14 h14
    18 - test-linux64/debug-mochitest-sw-e10s-10 10
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-13 h13
    18 - test-linux64/debug-mochitest-sw-e10s-6 6
    18 - test-linux64/debug-mochitest-sw-e10s-14 14
    18 - test-linux64/debug-mochitest-sw-e10s-13 13
    18 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
    18 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-10 h10
    18 - test-linux64/debug-mochitest-sw-e10s-16 16
    18 - test-linux64/debug-mochitest-e10s-12 12
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-16 h16
    18 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-3 h3
    18 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
    18 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
    18 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
    18 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
    18 - test-linux64/debug-mochitest-plain-headless-sw-e10s-7 h7
    16 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    16 - test-linux64/debug-telemetry-tests-client-e10s c
    16 - test-linux64/debug-mochitest-plain-headless-sw-e10s-12 h12
    16 - test-linux64/debug-mochitest-e10s-13 13
    16 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
    16 - test-linux64/debug-mochitest-sw-e10s-12 12
    16 - test-linux64/debug-mochitest-gpu-e10s gpu
    14 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
    12 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
    12 - test-linux64/debug-mochitest-e10s-2 2
    12 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
    12 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
    12 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
    12 - test-linux64/debug-mochitest-media-e10s-3 mda3
    12 - test-linux64/debug-mochitest-sw-e10s-2 2
    11 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
    10 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
    10 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
     9 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
     8 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
     8 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
     8 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
     8 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
     8 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
     8 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
     6 - test-linux64/debug-mochitest-media-e10s-2 mda2
     6 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
     6 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
     6 - test-linux64/debug-mochitest-media-e10s-1 mda1
     4 - test-linux64/debug-reftest-e10s-8 R8
     4 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
     4 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
     4 - test-linux64/debug-reftest-sw-e10s-8 R8
     4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
     4 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
     4 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
     4 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
     4 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
     4 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
     2 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
     2 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
     2 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
     2 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
     2 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
     2 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
     2 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
     2 - test-linux64/debug-mochitest-a11y-sw a11y
     2 - test-linux64/debug-mochitest-a11y a11y
     2 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
     2 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
     2 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
     2 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
     2 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
     2 - test-linux64/debug-crashtest-sw-e10s C
     2 - test-linux64/debug-crashtest-e10s C
     2 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
     2 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
     2 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
     1 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9

It shows up in 1942 tests. A few of the most prevalent:

  2300 - [e10s] Shutdown
   396 -        Shutdown
    72 -        browser/components/shell/test/test_headless_screenshot.html
    24 - [e10s] /webdriver/tests/get_page_source/user_prompts.py
    24 - [e10s] /webdriver/tests/find_element_from_element/user_prompts.py
    24 - [e10s] js/xpconnect/tests/marionette/test_loader_global_sharing.py TestLoaderGlobalSharing.test_global_sharing_settings
    24 - [e10s] /webdriver/tests/find_elements_from_element/user_prompts.py
    24 - [e10s] /webdriver/tests/get_element_css_value/user_prompts.py
    24 - [e10s] /webdriver/tests/get_element_tag_name/user_prompts.py
    24 - [e10s] /webdriver/tests/element_clear/user_prompts.py

[1] https://hg.mozilla.org/mozilla-central/annotate/d5549e46baed/xpcom/base/MemoryTelemetry.cpp#l304

This is coming from the REPORT define when measuring VsizeMaxContiguous which isn't actually available on linux.

Don't warn about measurements that aren't available for the current platform.

Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c195b373b43a
Reduce scope of memory telemetry warning. r=kmag

https://hg.mozilla.org/mozilla-central/rev/c195b373b43a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → erahm
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: