1523347 - z-order is wrong on CSS 3D animation (plane-splitting)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Alice0775 White]

Attachment: screemshot

STR

1. WebRender enabled
2. Open https://bugzilla.mozilla.org/attachment.cgi?id=8669060

Actual results:
z-order is wrong
Gap appears

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Reduced test case of the seam

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Here's a diff of the plane splitter:

 plane_split::polygon: 		Outside of the plane
 plane_split::polygon: 		Outside of the plane
 plane_split::bsp: 	Cutting anchor 2 by 0
-plane_split::bsp: 		Cut across Line { origin: (1154.2432196166337,491.15539994192574,24.748330044050704), dir: (0.3391779071611998,-0.7698454598525946,-0.5406443518969709) }
+plane_split::bsp: 		Cut across Line { origin: (1192.8881942663995,551.4414432650749,-36.8511719889799), dir: (0.33917790250093166,-0.7698454636305868,-0.5406443494409939) }
 plane_split::polygon: 	Splitting
 plane_split::polygon: 		Reached complex case [0, 2]
 plane_split::polygon: 		Outside of the plane
@@ -18470,10 +18470,10 @@
 plane_split::polygon: 		Outside of the plane
 plane_split::bsp: 	Cutting anchor 5 by 0
 plane_split::polygon: 		One is completely outside of the other
-plane_split::bsp: 		Outside at 1242.3637538420658
+plane_split::bsp: 		Outside at 1242.3639900313156
 plane_split::bsp: 	Cutting anchor 5 by 2
 plane_split::polygon: 		One is completely outside of the other
-plane_split::bsp: 		Outside at 2.1987183859946526
+plane_split::bsp: 		Outside at 2.1990305838471613
 plane_split::polygon: 		Outside of the plane
 plane_split::polygon: 		Outside of the plane
 plane_split::polygon: 		Outside of the plane
@@ -18481,10 +18481,10 @@
 plane_split::polygon: 		Outside of the plane
 plane_split::bsp: 	Cutting anchor 7 by 0
 plane_split::polygon: 		One is completely outside of the other
-plane_split::bsp: 		Outside at 1270.4640159750782
+plane_split::bsp: 		Outside at 1270.4641076170947
 plane_split::bsp: 	Cutting anchor 7 by 2
 plane_split::bsp: 		Normals roughly point to the same direction
-plane_split::bsp: 		Coplanar at 0.00002822191163431853
+plane_split::bsp: 		Coplanar at 0.00003835763254755875

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: The scene of broken

Comment 4

[Dzmitry Malyshau [:kvark]]

It looks like the gap was appearing because of screen space rasterization, and is now fixed. I'll start looking into why the order got wrong.

Comment 5

[Dzmitry Malyshau [:kvark]]

Fixed upstream

Comment 6

[Dzmitry Malyshau [:kvark]]

Attachment: Plane-split update to 0.13.4

new version includes necessary quality fixes for plane-splitting

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb5ed33ae30d
Plane-split update to 0.13.4 r=kats

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/cb5ed33ae30d