Use source map worker hasOriginalURL when viewing sources in the debugger

RESOLVED FIXED in Firefox 67

Status

enhancement
P1
normal
RESOLVED FIXED
5 months ago
2 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

5 months ago
Posted patch patchSplinter Review

As explained in https://github.com/devtools-html/debugger.html/pull/7819, console links to debugger sources can go to the wrong place if the debugger hasn't seen the source yet but is in the process of loading it. PR 7819 adds a fix for this via a hasOriginalURL API in the source map worker, but m-c needs to be updated to use this API. The attached patch does this, and fixes a test so that we wait for the source to finish loading if we end up selecting a pending location this way.

Attachment #9039654 - Flags: review?(jlaster)
Assignee

Updated

5 months ago
Assignee: nobody → bhackett1024
Comment on attachment 9039654 [details] [diff] [review]
patch

Review of attachment 9039654 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good assuming we can re-enable console-nosource
Attachment #9039654 - Flags: review?(jlaster) → review+
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 2

5 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf6dc155439
Always view source map original URLs in the debugger, r=jlast.

Brian, could you enable the webxonsole nosource test?

Flags: needinfo?(bhackett1024)

Comment 4

5 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96f507c9b96c
Reenable browser_webconsole_sourcemap_nosource.js mochitest.
Assignee

Updated

5 months ago
Flags: needinfo?(bhackett1024)

Comment 5

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.