Closed
Bug 1523421
Opened 5 years ago
Closed 5 years ago
Use source map worker hasOriginalURL when viewing sources in the debugger
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
As explained in https://github.com/devtools-html/debugger.html/pull/7819, console links to debugger sources can go to the wrong place if the debugger hasn't seen the source yet but is in the process of loading it. PR 7819 adds a fix for this via a hasOriginalURL API in the source map worker, but m-c needs to be updated to use this API. The attached patch does this, and fixes a test so that we wait for the source to finish loading if we end up selecting a pending location this way.
Attachment #9039654 -
Flags: review?(jlaster)
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → bhackett1024
|
||
Comment 1•5 years ago
|
||
Comment on attachment 9039654 [details] [diff] [review] patch Review of attachment 9039654 [details] [diff] [review]: ----------------------------------------------------------------- Looks good assuming we can re-enable console-nosource
Attachment #9039654 -
Flags: review?(jlaster) → review+
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf6dc155439 Always view source map original URLs in the debugger, r=jlast.
|
|
||
Comment 3•5 years ago
|
||
Brian, could you enable the webxonsole nosource test?
Flags: needinfo?(bhackett1024)
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/96f507c9b96c Reenable browser_webconsole_sourcemap_nosource.js mochitest.
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(bhackett1024)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0bf6dc155439
https://hg.mozilla.org/mozilla-central/rev/96f507c9b96c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•