1523421 - Use source map worker hasOriginalURL when viewing sources in the debugger

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

As explained in https://github.com/devtools-html/debugger.html/pull/7819, console links to debugger sources can go to the wrong place if the debugger hasn't seen the source yet but is in the process of loading it. PR 7819 adds a fix for this via a hasOriginalURL API in the source map worker, but m-c needs to be updated to use this API. The attached patch does this, and fixes a test so that we wait for the source to finish loading if we end up selecting a pending location this way.

Comment 1

[Jason Laster [:jlast]]

Comment on attachment 9039654 [details] [diff] [review]
patch

Review of attachment 9039654 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good assuming we can re-enable console-nosource

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf6dc155439
Always view source map original URLs in the debugger, r=jlast.

Comment 3

[Jason Laster [:jlast]]

Brian, could you enable the webxonsole nosource test?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96f507c9b96c
Reenable browser_webconsole_sourcemap_nosource.js mochitest.

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0bf6dc155439
https://hg.mozilla.org/mozilla-central/rev/96f507c9b96c