Closed Bug 1523430 Opened 5 years ago Closed 5 years ago

Using a continue file for background staging causes intermittent browser chrome test failures

Categories

(Toolkit :: Application Update, defect)

59 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review

Spinoff of bug 1522941 since the patch I submitted in that bug won't fix the intermittent test failure in that bug but it should fix other intermittent test failures.

The attached patch already has r+ from mhowell in bug 1522941 so carrying forward r+

Attachment #9039664 - Flags: review+

The relevant failure from the log of a try push
19:22:13 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_bc_downloaded_staged.js | Test timed out -
19:22:13 INFO - Not taking screenshot here: see the one that was previously logged
19:22:13 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutDialog_bc_downloaded_staged.js | A promise chain failed to handle a rejection: Waiting for file to be deleted, path: /Users/cltbld/Library/Caches/Mozilla/updates/Users/cltbld/tasks/task_1548634734/build/application/Firefox Nightly/updates/0/continueStaging - timed out after 200 tries. - stack: (No stack available.)
19:22:13 INFO - Rejection date: Sun Jan 27 2019 19:21:48 GMT-0800 (Pacific Standard Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257

Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18815665f545
Don't use a continue file for background staging browser chrome tests since it causes intermittent failures. r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: