Skip test_videocontrols_onclickplay.html test

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee: nobody → sotaro.ikeda.g
Blocks: 1520705

test_videocontrols_onclickplay.html belongs to mochitest-chrome and it runs test with e10s disabled. It caused hitting the assert.

(In reply to Sotaro Ikeda [:sotaro] from comment #1)

test_videocontrols_onclickplay.html belongs to mochitest-chrome and it runs test with e10s disabled. It caused hitting the assert.

In this case ImageBridgeChild::UpdateTextureFactoryIdentifier() is called at first for LayersBackend::LAYERS_WR and then for LayersBackend::LAYERS_BASIC.

(In reply to Sotaro Ikeda [:sotaro] from comment #2)

In this case ImageBridgeChild::UpdateTextureFactoryIdentifier() is called at first for LayersBackend::LAYERS_WR and then for LayersBackend::LAYERS_BASIC.

ImageBridgeChild::UpdateTextureFactoryIdentifier() for LayersBackend::LAYERS_BASIC was always called for eWindowType_invisible in parent process. The testing test_videocontrols_onclickplay.html run with e10s disabled, then it caused hitting the assert.

Attachment #9040006 - Attachment description: Do not call ImageBridgeChild::IdentifyCompositorTextureHost() for eWindowType_invisible → patch - Do not call ImageBridgeChild::IdentifyCompositorTextureHost() for eWindowType_invisible
See Also: → 1525515
Comment on attachment 9040030 [details] [diff] [review]
patch - Do not call ImageBridgeChild::IdentifyCompositorTextureHost() for non-webrender widget

This patch is not a good way to address the test failure.
Attachment #9040030 - Attachment is obsolete: true

I re-think about test_videocontrols_onclickplay.html. The test run with e10s disabled, and the test failure happens by disabling e10s. But WebRender is not used on windows with disabling e10s. Then we could skip the test for MVP.

Summary: Fix hitting ASSERT during test_videocontrols_onclickplay.html test → Skip test_videocontrols_onclickplay.html test
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/164bfd05f3f7
Skip test_videocontrols_onclickplay.html r=jrmuizel
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.