1523527 - remove 'dummy' binding's uses in c-c

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:aceman]

The 'dummy' binding removed in bug 1514208 is still referenced:
WARNING: Unable to locate an XBL binding for URI chrome://messenger/content/mailWidgets.xml#dummy in document chrome://messenger/content/FilterEditor.xul: file mozilla/dom/xbl/nsXBLService.cpp, line 766

At https://searchfox.org/comm-central/source/mail/base/content/messenger.css#77

dummy.usesMailWidgets {
-moz-binding: url("chrome://messenger/content/mailWidgets.xml#dummy");
}

This dummy element is in many of our files:

mail/base/content/ABSearchDialog.xul
60 <dummy class="usesMailWidgets"/>
mail/base/content/SearchDialog.xul
80 <dummy class="usesMailWidgets"/>
mail/base/content/messenger.css
76 dummy.usesMailWidgets {
mail/extensions/mailviews/content/mailViewSetup.xul
38 <dummy class="usesMailWidgets"/>
mailnews/base/search/content/FilterEditor.xul
32 <dummy class="usesMailWidgets"/>

It has no effect now as the binding is gone, so we try to remove all these.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1523527-remove-dummy.patch

Like this?

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9039726 [details] [diff] [review]
1523527-remove-dummy.patch

Review of attachment 9039726 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, not sure why I didn't notice this! r=mkmelin

Comment 3

[Richard Marti (:Paenglab)]

Jörg, can you change the reviewer to r=mkmelin when you land it?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/534dd6adf201
Bug 1514208 follow-up: Remove dummy elements in C-C. r=mkmelin