Closed Bug 1523540 Opened 10 months ago Closed 10 months ago

Remove WIN64_LIB and WIN64_LINK

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Now that everything is lined up nicely, we don't need those anymore.

Now that everything is lined up nicely, we don't need those anymore.

We can fill cargo-linker.bat with HOST_LINKER and HOST_LINKER_LIBPATHS,
which, unfortunately, can't be used as is, so we add a variant for
substitution in .bat files.

I wonder if we could tweak the cc crate to support executing .bat scripts as compilers like rustc does for linkers:
https://github.com/rust-lang/rust/blob/d2048b6db375299b681d4f4728b8e7cad9f74d5f/src/librustc_codegen_llvm/back/link.rs#L59

That would let us work around the stuff that's not letting us pass compilers down to build scripts currently:
https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/config/rules.mk#917

I opened an issue on the cc crate for that: https://github.com/alexcrichton/cc-rs/issues/369

We don't actually need .bat wrapping for the compiler. I have other plans for how to fix that thing you've pointed at that's essentially responsible for bug 1522614: just avoiding cargo being invoked via msys by make.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/65d6a89d1eae
Remove WIN64_LIB and WIN64_LINK. r=ted
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Got some nice build time improvements on Windows 32bit platforms! \0/

== Change summary for alert #19056 (as of Wed, 30 Jan 2019 20:47:15 GMT) ==

Improvements:

35% build times windows2012-32 debug rusttests taskcluster-c5.4xlarge 664.37 -> 432.36
31% build times windows2012-32 debug rusttests taskcluster-c4.4xlarge 856.33 -> 587.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19056

I... wasn't expecting that.

Blocks: 1524396
You need to log in before you can comment on or make changes to this bug.