1523540 - Remove WIN64_LIB and WIN64_LINK

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Now that everything is lined up nicely, we don't need those anymore.

Comment 1

[(not currently active) Ted Mielczarek]

👍

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1523540 - Remove WIN64_LIB and WIN64_LINK.

Now that everything is lined up nicely, we don't need those anymore.

We can fill cargo-linker.bat with HOST_LINKER and HOST_LINKER_LIBPATHS,
which, unfortunately, can't be used as is, so we add a variant for
substitution in .bat files.

Comment 3

[(not currently active) Ted Mielczarek]

I wonder if we could tweak the cc crate to support executing .bat scripts as compilers like rustc does for linkers:
https://github.com/rust-lang/rust/blob/d2048b6db375299b681d4f4728b8e7cad9f74d5f/src/librustc_codegen_llvm/back/link.rs#L59

That would let us work around the stuff that's not letting us pass compilers down to build scripts currently:
https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/config/rules.mk#917

Comment 4

[(not currently active) Ted Mielczarek]

I opened an issue on the cc crate for that: https://github.com/alexcrichton/cc-rs/issues/369

Comment 5

[Mike Hommey [:glandium]]

We don't actually need .bat wrapping for the compiler. I have other plans for how to fix that thing you've pointed at that's essentially responsible for bug 1522614: just avoiding cargo being invoked via msys by make.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65d6a89d1eae
Remove WIN64_LIB and WIN64_LINK. r=ted

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/65d6a89d1eae

Comment 8

[Ionuț Goldan [:igoldan]]

Got some nice build time improvements on Windows 32bit platforms! \0/

== Change summary for alert #19056 (as of Wed, 30 Jan 2019 20:47:15 GMT) ==

Improvements:

35% build times windows2012-32 debug rusttests taskcluster-c5.4xlarge 664.37 -> 432.36
31% build times windows2012-32 debug rusttests taskcluster-c4.4xlarge 856.33 -> 587.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19056

Comment 9

[Mike Hommey [:glandium]]

I... wasn't expecting that.