Ubuntu 18.10: Maximized windows have round corners

VERIFIED FIXED in Firefox 66

Status

()

defect
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: dao, Assigned: stransky)

Tracking

(Blocks 1 bug, {regression})

unspecified
mozilla67
Unspecified
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 verified, firefox67 verified)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

I'm guessing bug 1521012 didn't take the window state into account.

Updated

5 months ago
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1522774
Reporter

Comment 2

5 months ago

Not a duplicate of bug 1522774.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee

Updated

4 months ago
Assignee: nobody → stransky

Updated

4 months ago
Duplicate of this bug: 1522774
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 6

4 months ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f946a261f4fc
[Linux/Gtk+] Don't apply titlebar shape mask to maximized windows, r=dao

Keywords: checkin-needed

Comment 7

4 months ago
bugherder
Status: REOPENED → RESOLVED
Closed: 5 months ago4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Should we uplift this to 66?

Flags: needinfo?(stransky)
Assignee

Comment 9

4 months ago

Comment on attachment 9041753 [details]
Bug 1523556 - [Linux/Gtk+] Don't apply titlebar shape mask to maximized windows, r=dao

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1521012

User impact if declined

Transparent round corners when system titlebar is disabled and Firefox window is maximized in Gnome classic.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Minor Linux/Gtk+ fix.

String changes made/needed

none

Flags: needinfo?(stransky)
Attachment #9041753 - Flags: approval-mozilla-beta?

Comment on attachment 9041753 [details]
Bug 1523556 - [Linux/Gtk+] Don't apply titlebar shape mask to maximized windows, r=dao

GTK only fix, fine for beta 11 uplift.

Attachment #9041753 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [qa-triaged]

Comment 12

4 months ago

Hi,

I was able to reproduce this issue on Ubuntu 18.04.1 using Firefox Beta 66.0b10(2019-02-22)

I've also checked on the Latest Firefox Nightly 67.0a1(20190226093755) / Firefox Beta 66.0b11(20190225143245) and it is now fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.